x/build: add LUCI solaris-amd64 builder

[rorth]

s11-i386.foss.cebitec.uni-bielefeld.de.csr.txt

Somehow I'm not able to add the new-builder as required in the installation docs.

[cagedmantis]

@roth The instructions have been updated with a method on how to add the new-builder label via gopherbot.

[cagedmantis]

Please generate a new certificate signing request using solaris-amd64 as the hostname. I will clarify the documentation. The hostname will be what the host will appear as in the build environment. It's not necessarily what the actual hostname is.

[rorth]

I see. I'd already wondered if the fqdn would be desired here.
solaris-amd64.csr.txt

[cagedmantis]

solaris-amd64-1690923319.cert.txt
I've generated the cert and registered your bot.

[rorth]

Hi Carlos,

[solaris-amd64-1690923319.cert.txt](https://github.com/golang/go/files/12233926/solaris-amd64-1690923319.cert.txt) I've generated the cert and registered your bot.

Thanks. As I'd mentioned, I've got the luci_machine_tokend running with that now. However, trying run bootstrapswarm next got me into a new problem: the log shows 2023/08/02 15:59:52 Bootstrapping the swarming bot with certificate authentication 2023/08/02 15:59:52 retrieving the luci-machine-token from the token file 2023/08/02 15:59:52 Downloading the swarming bot 2023/08/02 15:59:54 Starting the swarming bot /opt/golang/.swarming/swarming_bot.zip 4104 2023-08-02 13:59:56.578 E: ts_mon monitoring is disabled because the endpoint provided is invalid or not supported: 4104 2023-08-02 13:59:56.579 E: os.utilities.get_hostname_short() failed Traceback (most recent call last): File "/opt/golang/.swarming/swarming_bot.1.zip/bot_code/bot_main.py", line 385, in _get_botid_safe return os_utilities.get_hostname_short() File "/opt/golang/.swarming/swarming_bot.1.zip/utils/tools.py", line 211, in wrapper v = func(*args) File "/opt/golang/.swarming/swarming_bot.1.zip/api/os_utilities.py", line 421, in get_hostname_short return get_hostname().split('.', 1)[0] File "/opt/golang/.swarming/swarming_bot.1.zip/utils/tools.py", line 211, in wrapper v = func(*args) File "/opt/golang/.swarming/swarming_bot.1.zip/api/os_utilities.py", line 399, in get_hostname if platforms.is_gce() and not os.path.isfile('/.dockerenv'): AttributeError: module 'api.platforms' has no attribute 'is_gce' Traceback (most recent call last): File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main "__main__", mod_spec) File "/usr/lib/python3.7/runpy.py", line 85, in _run_code exec(code, run_globals) File "/opt/golang/.swarming/swarming_bot.1.zip/__main__.py", line 336, in <module> File "/opt/golang/.swarming/swarming_bot.1.zip/__main__.py", line 324, in main File "/opt/golang/.swarming/swarming_bot.1.zip/__main__.py", line 203, in CMDstart_bot File "/opt/golang/.swarming/swarming_bot.1.zip/bot_code/bot_main.py", line 2218, in main File "/opt/golang/.swarming/swarming_bot.1.zip/bot_code/bot_main.py", line 1130, in _run_bot File "/opt/golang/.swarming/swarming_bot.1.zip/bot_code/bot_main.py", line 1168, in _run_bot_inner AttributeError: module 'api.platforms' has no attribute 'is_gce' Sending the crash report ... done. Report URL: https://chromium-swarm.appspot.com/restricted/ereporter2/errors/5378321203200000 Process exited due to exception module 'api.platforms' has no attribute 'is_gce' 2023/08/02 15:59:57 command execution /usr/bin/python3 /opt/golang/.swarming/swarming_bot.zip start_bot: exit status 1 Looking at the python code, I find (in api/os_utilities.py): def get_hostname_short(): """Returns the base host name.""" return get_hostname().split('.', 1)[0] The machine's hostname is "s11-i386.foss", i.e. it's qualified, but not an FQDN. The function above thus yields "s11-i386", which cannot be resolved. In this case, the host's fqdn is s11-i386.foss.cebitec.uni-bielefeld.de, the domain part being cebitec.uni-bielefeld.de. Maybe one could use a heuristic of checking for more than 1 dot to distinguish between unqualied hostnames and fqdn, or, better yet, let the admin decide what they prefer for hostname conventions? Besides, I've got a couple of other questions: * How can I control the parallelism of the resulting bot? Just with GOMAXPROCS in the bot's environment? That's particularly important for this host which co-hosts other buildbots which shouldn't interfere with each other by overtaking the whole machine. * Same for the bot's working directory. Is this hardcoded as $HOME/.swarming? Thanks. Rainer

[cagedmantis]

cc/ @golang/release

[cagedmantis]

@roth We've looked into this error. The swarming bot doesn't seem to support solaris-amd64. Thanks for doing this work, it revealed that this would be an issue. We added the work to add support to our roadmap. I will comment on this issue once that work has started.