Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln: compute proper symbol name for generic methods #63535

Closed
zpavlinovic opened this issue Oct 13, 2023 · 2 comments
Closed

x/vuln: compute proper symbol name for generic methods #63535

zpavlinovic opened this issue Oct 13, 2023 · 2 comments
Assignees
@zpavlinovic
Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@zpavlinovic
Copy link
Contributor

dbFuncName is not correct for generic methods and their instantiations. It is currently returning just the name of the type without type parameters, completely skipping the method name.

For a type Foo[...] and its method Bar, we should generate the name Foo.Bar.
@zpavlinovic zpavlinovic added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Oct 13, 2023
@zpavlinovic zpavlinovic self-assigned this Oct 13, 2023
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Oct 13, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/548016 mentions this issue: internal/vulncheck: compute proper db names for generic functions

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/548195 mentions this issue: internal/symbols: compute proper db names for generic functions

gopherbot pushed a commit to golang/vuln that referenced this issue Dec 13, 2023
@zpavlinovic
internal/vulncheck: compute proper db names for generic functions
53a5385 
These should not include the type parameter/argument.

Updates golang/go#63535

Change-Id: Iaae0e587d365f7e26e2361c9814fa1d288d8ad86
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/548016
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
Reviewed-by: Maceo Thompson <maceothompson@google.com>
@golang golang locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zpavlinovic zpavlinovic

Labels
FrozenDueToAge vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/unplanned
Development

No branches or pull requests
2 participants
@zpavlinovic @gopherbot