Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: linux/s390x: inlining bug in s390x [1.21 backport] #64472

Closed
gopherbot opened this issue Nov 30, 2023 · 3 comments
Closed

cmd/compile: linux/s390x: inlining bug in s390x [1.21 backport] #64472

gopherbot opened this issue Nov 30, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.21.6

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #64468 to be considered for backport to the next 1.21 minor release.

@gopherbot please open a backport issue for 1.21.

This is a pretty serious miscompilation with no easy workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 30, 2023
@gopherbot gopherbot mentioned this issue Nov 30, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 30, 2023
@gopherbot gopherbot added this to the Go1.21.5 milestone Nov 30, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/546356 mentions this issue: [release-branch.go1.21] cmd/compile: fix memcombine pass for big endian, > 1 byte elements

@gopherbot gopherbot modified the milestones: Go1.21.5, Go1.21.6 Dec 5, 2023
@cagedmantis
Copy link
Contributor

Approved. It's a serious issue without a workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Dec 6, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 6, 2023
gopherbot pushed a commit that referenced this issue Dec 6, 2023
@randall77 @cagedmantis
[release-branch.go1.21] cmd/compile: fix memcombine pass for big endi…
8c840b1 
…an, > 1 byte elements

The shift amounts were wrong in this case, leading to miscompilation
of load combining.

Also the store combining was not triggering when it should.

Fixes #64472

Change-Id: Iaeb08972c5fc1d6f628800334789c6af7216e87b
Reviewed-on: https://go-review.googlesource.com/c/go/+/546355
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/546356
@gopherbot
Copy link
Contributor Author

Closed by merging 8c840b1 to release-branch.go1.21.

@golang golang locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.21.6
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot