-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: add a Linux LUCI builder with a recent Clang toolchain #64563
Comments
See #64400 , cmd/cgo/internal/testtls if the failure is not Windows-specific, the new builder may see the same failure. But I haven't tried to test it on linux. |
Change https://go.dev/cl/559255 mentions this issue: |
Assuming that all works well with this attempt to add a clang builder to LUCI, I've also sent out a CL on documentation on how to add new builders for new clang versions and how to update clang minor versions. It should be easy after this to just add as many clang builders as we want, for whatever version we want to test. |
This change adds the clang16 builder type so we have at least one builder where the C toolchain is clang. This is to help align the LUCI builders with the old infrastructure. For golang/go#61101. For golang/go#64563. Change-Id: I8b0ef5d02c8fec8eeea6664d2abde5d676d09634 Reviewed-on: https://go-review.googlesource.com/c/build/+/559255 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Bypass: Michael Knyszek <mknyszek@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
There's a LUCI builder with clang 15 (e.g., gotip-linux-amd64-clang15) and it's been working okay for a while, so I think we can close this out. (There were some additional issues uncovered initially, and I believe they're resolved by now. A separate issue #65356 tracks more work for future clang 16+ builders.) Thanks @mknyszek. |
As noted in #64423 (comment), there is a
cmd/go
test that currently fails with Clang 14.0.6, but passes on thelinux-amd64-clang
post-commit builder (https://build.golang.org/log/f99f0dad3b4c5e7ad8da042b9f541a02313edc02), presumably because theclang
version installed on that builder is very old (7.0.1, released December 2018) and reports its version differently.It appears that the most recent Clang release is 17.0.6, released Nov. 28, 2023.
We expect Go users to upgrade to the latest supported release within ~one year. We should at least test against our own dependencies with the same promptness, which would imply a builder with at least least Clang 15.
The text was updated successfully, but these errors were encountered: