Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/tests/deps: TestCmdPkgsiteDeps failing on js/wasm due to lack of exec support #64942

Closed
bcmills opened this issue Jan 3, 2024 · 2 comments
Closed

x/pkgsite/internal/tests/deps: TestCmdPkgsiteDeps failing on js/wasm due to lack of exec support #64942

bcmills opened this issue Jan 3, 2024 · 2 comments
Assignees
@matloob
Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 3, 2024 •
edited
Loading 

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/tests/deps" && test == "TestCmdPkgsiteDeps" && `exec: "go": executable file not found in $PATH` && date < "2024-01-04"

Go version

c95fe91

What operating system and processor architecture are you using (go env)?

:: Running /workdir/go/bin/go with args ["/workdir/go/bin/go" "test" "-short" "./..."] and env ["HOSTNAME=buildlet-linux-amd64-js-wasm-node18-rn72e0494" "DEBIAN_FRONTEND=noninteractive" "HOME=/root" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=js-wasm-node18" "GOOS=js" "GOARCH=wasm" "GOHOSTOS=linux" "GOHOSTARCH=amd64" "GO_DISABLE_OUTBOUND_NETWORK=1" "GOROOT=/workdir/go" "GOPATH=/workdir/gopath" "GOPROXY=http://gk3-services-nap-jetxd907-8f582974-hv4r.c.symbolic-datum-552.internal:30157" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache" "GOPLSCACHE=/workdir/goplscache" "PATH=/workdir/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/workdir/go/misc/wasm" "PWD=/workdir/gopath/src/golang.org/x/pkgsite"] in dir /workdir/gopath/src/golang.org/x/pkgsite

What did you do?

Check build status at https://build.golang.org/?repo=golang.org%2fx%2fpkgsite.

What did you expect to see?

All tests passing.

What did you see instead?

https://build.golang.org/log/60d543c1c0a966e10b9ccbfa67714f9755dbab21:

js-wasm-node18 at c95fe91d0715dc0a8d55ac80a80f383c3635548b building pkgsite at 475d4c57676e9e93276be3b802aaa7e758610ead
…
--- FAIL: TestCmdPkgsiteDeps (0.00s)
    cmd_pkgsite_deps_test.go:36: running go list:  exec: "go": executable file not found in $PATH
FAIL
FAIL	golang.org/x/pkgsite/internal/tests/deps	0.336s

This test should call testenv.MustHaveExecPath(t, "go") to skip on platforms that do not support exec.

(attn @matloob)
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 3, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 3, 2024
@bcmills bcmills mentioned this issue Jan 3, 2024
Open
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/553695 mentions this issue: internal/tests/deps: skip test if we can't run go command

@dmitshur dmitshur added the arch-wasm WebAssembly issues label Jan 3, 2024
gopherbot pushed a commit to golang/pkgsite that referenced this issue Jan 3, 2024
@matloob
internal/tests/deps: skip test if we can't run go command
a0bbdd6 
For golang/go#64942

Change-Id: Idffad578d4bb766dd5c9d8d1a500b8f68598b664
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/553695
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
@bcmills
Copy link
Contributor Author

bcmills commented Jan 3, 2024

Fixed by https://go.dev/cl/553695.

@bcmills bcmills closed this as completed Jan 3, 2024
@gabyhelp gabyhelp mentioned this issue Jun 16, 2024
Closed
@golang golang locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matloob matloob

Labels
arch-wasm WebAssembly issues FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @matloob