x/telemetry/internal/regtest: test consistently failing on many platforms since CL 560462

[bcmills]

#!watchflakes
post <- pkg == "golang.org/x/telemetry/internal/regtest" && (
	goarch == "386" ||
	goarch == "wasm" ||
	goos == "android" ||
	goos == "illumos" ||
	goos == "solaris" ||
	goos == "openbsd" ||
	goos == "plan9")

Go version

9819d82

Output of go env in your module/workspace:

N/A

What did you do?

Check builder status for #11811.

What did you see happen?

https://build.golang.org/log/3ea3d15a5b41086aeb875a6846533cb78175b83b:

--- FAIL: TestE2E (0.00s)
    e2e_test.go:145: unmet expectation:
        got {}
        want {
        	 "counter": 1,
        	 "gopls/editor:expected": 1,
        	 "stack/expected\n": 1
        	}
    e2e_test.go:152: unmet expectation:
        got {}
        want {
        	 "counter:surprise": 1,
        	 "gopls/editor:surprise": 1,
        	 "stack-surprise\n": 1
        	}
FAIL
FAIL	golang.org/x/telemetry/internal/regtest	0.024s

This affects all 386 platforms, including the first class ports for linux/386 and windows/386.

Similar failures occur on the android, illumos, js, openbsd, plan9, solaris, and wasip1 builders, although since those are secondary ports perhaps they are just misconfigured builders.

What did you expect to see?

All tests should be either passing or skipped, especially on first class ports such as linux/386 and windows/386.

For secondary ports that are intentionally not supported, either the tests should be skipped or the builders should be configured not to run them in the first place.

[bcmills]

It is also worth noting that this test does not meet the standard of https://go.dev/wiki/CodeReviewComments#useful-test-failures: it shows what was got and what was expected, but it does not describe “with what inputs” and doesn't report any errors encountered by the telemetry collection & upload process.

[findleyr]

I believe @pjweinb has a fix for this in https://go.dev/cl/561995.

CC @hyangah @matloob

[findleyr]

Nevermind, that CL removes the proxy API which I still believe is necessary. I'll send a fix for the builder breakage.

[gopherbot]

Change https://go.dev/cl/562076 mentions this issue: internal/regtest: skip TestE2E if telemetry is disabled on platform

[gopherbot]

Change https://go.dev/cl/562396 mentions this issue: counter/countertest: add returns to disabled functions that need them