-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/cgo/internal/testsanitizers,x/build: upstream clang does not build against zlib, so checking for ASAN symbolization is disabled during the ASAN tests #65606
Comments
Change https://go.dev/cl/562675 mentions this issue: |
Another benefit of keeping clang in CIPD is that it's easier to test multiple versions of clang, if we ever need to. (Though, given #65302 is still open at this time, it's not clear to me if that's necessary at this point.) |
Change https://go.dev/cl/562538 mentions this issue: |
Pending a resolution to #65606, this CL marks clang's ASAN runtime as unable to symbolize stack traces to unblock the LUCI clang builder. For #65606. Fixes #65469. Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/562675 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Change https://go.dev/cl/563015 mentions this issue: |
Change https://go.dev/cl/562999 mentions this issue: |
…tion checking for clang Pending a resolution to #65606, this CL marks clang's ASAN runtime as unable to symbolize stack traces to unblock the LUCI clang builder. For #65606. For #65469. Fixes #65640. Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2 Cq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/562675 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit d94ab59) Reviewed-on: https://go-review.googlesource.com/c/go/+/562999
…tion checking for clang Pending a resolution to #65606, this CL marks clang's ASAN runtime as unable to symbolize stack traces to unblock the LUCI clang builder. For #65606. For #65469. Fixes #65641. Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2 Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/562675 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit d94ab59) Reviewed-on: https://go-review.googlesource.com/c/go/+/563015
Pending a resolution to golang#65606, this CL marks clang's ASAN runtime as unable to symbolize stack traces to unblock the LUCI clang builder. For golang#65606. Fixes golang#65469. Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/562675 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
…tion checking for clang Pending a resolution to golang#65606, this CL marks clang's ASAN runtime as unable to symbolize stack traces to unblock the LUCI clang builder. For golang#65606. For golang#65469. Fixes golang#65641. Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2 Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/562675 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit d94ab59) Reviewed-on: https://go-review.googlesource.com/c/go/+/563015
…tion checking for clang Pending a resolution to golang#65606, this CL marks clang's ASAN runtime as unable to symbolize stack traces to unblock the LUCI clang builder. For golang#65606. For golang#65469. Fixes golang#65641. Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2 Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/562675 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit d94ab59) Reviewed-on: https://go-review.googlesource.com/c/go/+/563015
See #65469 (comment) for complete context.
For our LUCI infrastructure, we store an official clang toolchain release (https://releases.llvm.org/) in CIPD, and download it into our build environment on-demand. Previously, we just baked the toolchain into the image using an officially-maintained package for Debian (https://apt.llvm.org), but this made upgrading onerous enough that we were stayed on clang 7 (2018) for a long time.
Unfortunately, the official clang toolchain releases aren't built against zlib, and the Go toolchain compresses DWARF sections. When the ASAN runtime tries to symbolize the stack trace it takes, we get failures like:
The alternatives here are not ideal. They require either maintaining more images or complicating our clang update process significantly. For now, we've decided to just not check for symbolized output for our ASAN tests when building with clang. We bake GCC into our images, and GCC can symbolize the output, so we still have coverage on our debug information.
This issue tracks either:
The text was updated successfully, but these errors were encountered: