Skip to content

runtime: go1.22.0 test with -race will SIGSEGV or SIGBUS or Bad Pointer [1.22 backport] #65818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 20, 2024 · 2 comments
Closed

runtime: go1.22.0 test with -race will SIGSEGV or SIGBUS or Bad Pointer [1.22 backport] #65818

gopherbot opened this issue Feb 20, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.22.1

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #65783 to be considered for backport to the next 1.22 minor release.

@gopherbot Please open a backport issue for 1.22.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 20, 2024
@gopherbot gopherbot mentioned this issue Feb 20, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 20, 2024
@gopherbot gopherbot added this to the Go1.22.1 milestone Feb 20, 2024
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Feb 21, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 21, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/566475 mentions this issue: [release-branch.go1.22] cmd/compile: make jump table symbol static

gopherbot pushed a commit that referenced this issue Feb 27, 2024
@cherrymui @cagedmantis
[release-branch.go1.22] cmd/compile: make jump table symbol static
686662f 
The jump table symbol is accessed only from the function symbol
(in the same package), so it can be static. Also, if the function
is DUPOK and it is, somehow, compiled differently in two different
packages, the linker must choose the jump table symbol associated
to the function symbol it chose. Currently the jump table symbol
is DUPOK, so that is not guaranteed. Making it static will
guarantee that, as each copy of the function symbol refers to its
own jump table symbol.

Updates #65783.
Fixes #65818.

Change-Id: I27e051d01ef585d07700b75d4dfac5768f16441e
Reviewed-on: https://go-review.googlesource.com/c/go/+/565535
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 2908352)
Reviewed-on: https://go-review.googlesource.com/c/go/+/566475
@gopherbot
Copy link
Contributor Author

Closed by merging 686662f to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@cherrymui @bradfitz
[release-branch.go1.22] cmd/compile: make jump table symbol static
4fe1c06 
The jump table symbol is accessed only from the function symbol
(in the same package), so it can be static. Also, if the function
is DUPOK and it is, somehow, compiled differently in two different
packages, the linker must choose the jump table symbol associated
to the function symbol it chose. Currently the jump table symbol
is DUPOK, so that is not guaranteed. Making it static will
guarantee that, as each copy of the function symbol refers to its
own jump table symbol.

Updates golang#65783.
Fixes golang#65818.

Change-Id: I27e051d01ef585d07700b75d4dfac5768f16441e
Reviewed-on: https://go-review.googlesource.com/c/go/+/565535
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 2908352)
Reviewed-on: https://go-review.googlesource.com/c/go/+/566475
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@cherrymui @romaindoumenc
[release-branch.go1.22] cmd/compile: make jump table symbol static
63463f9 
The jump table symbol is accessed only from the function symbol
(in the same package), so it can be static. Also, if the function
is DUPOK and it is, somehow, compiled differently in two different
packages, the linker must choose the jump table symbol associated
to the function symbol it chose. Currently the jump table symbol
is DUPOK, so that is not guaranteed. Making it static will
guarantee that, as each copy of the function symbol refers to its
own jump table symbol.

Updates golang#65783.
Fixes golang#65818.

Change-Id: I27e051d01ef585d07700b75d4dfac5768f16441e
Reviewed-on: https://go-review.googlesource.com/c/go/+/565535
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 2908352)
Reviewed-on: https://go-review.googlesource.com/c/go/+/566475
@golang golang locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
2 participants
@prattmic @gopherbot