Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: "missing ziphash" error with go.work [1.22 backport] #65852

Closed
gopherbot opened this issue Feb 21, 2024 · 3 comments
Closed

cmd/go: "missing ziphash" error with go.work [1.22 backport] #65852

gopherbot opened this issue Feb 21, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.22.1

Comments

@gopherbot
Copy link
Contributor

@matloob requested issue #62663 to be considered for backport to the next 1.22 minor release.

@gopherbot please open backport issues
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Feb 21, 2024
@gopherbot gopherbot mentioned this issue Feb 21, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.1 milestone Feb 21, 2024
@matloob
Copy link
Contributor

matloob commented Feb 21, 2024

We want to create backports for this because there was a regression in the behavior of go mod verify in workspaces in go 1.21.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/565775 mentions this issue: [release-branch.go1.22] cmd/go/internal/modcmd: correctly filter out main modules in verify

@matloob matloob added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 21, 2024
mgabeler-lee-6rs added a commit to 6RiverSystems/gosix that referenced this issue Feb 28, 2024
@mgabeler-lee-6rs
fix: workaroudn golang/go#65852
b94cafc
gopherbot pushed a commit that referenced this issue Feb 28, 2024
@matloob @cagedmantis
[release-branch.go1.22] cmd/go/internal/modcmd: correctly filter out …
d8c4239 
…main modules in verify

This change fixes a bug where we incorrectly filtered out the main
modules from the beginning of the build list before verifying them. We
made the assumption that the first MainModules.Len() entries of the
build list were the main modules, but now it can contain the go and
toolchain version entries, so removing the first MainModules.Len()
entries could leave main module names in the build list if any of
their names sorted after the string 'go'.

For #62663
Fixes #65852

Change-Id: I35ab6857a556f58d306303322afe24c48fc8b38f
Reviewed-on: https://go-review.googlesource.com/c/go/+/565378
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 3f60da7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/565775
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging d8c4239 to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@matloob @bradfitz
[release-branch.go1.22] cmd/go/internal/modcmd: correctly filter out …
c0aba15 
…main modules in verify

This change fixes a bug where we incorrectly filtered out the main
modules from the beginning of the build list before verifying them. We
made the assumption that the first MainModules.Len() entries of the
build list were the main modules, but now it can contain the go and
toolchain version entries, so removing the first MainModules.Len()
entries could leave main module names in the build list if any of
their names sorted after the string 'go'.

For golang#62663
Fixes golang#65852

Change-Id: I35ab6857a556f58d306303322afe24c48fc8b38f
Reviewed-on: https://go-review.googlesource.com/c/go/+/565378
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 3f60da7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/565775
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@matloob @romaindoumenc
[release-branch.go1.22] cmd/go/internal/modcmd: correctly filter out …
9519121 
…main modules in verify

This change fixes a bug where we incorrectly filtered out the main
modules from the beginning of the build list before verifying them. We
made the assumption that the first MainModules.Len() entries of the
build list were the main modules, but now it can contain the go and
toolchain version entries, so removing the first MainModules.Len()
entries could leave main module names in the build list if any of
their names sorted after the string 'go'.

For golang#62663
Fixes golang#65852

Change-Id: I35ab6857a556f58d306303322afe24c48fc8b38f
Reviewed-on: https://go-review.googlesource.com/c/go/+/565378
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 3f60da7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/565775
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Matloob <matloob@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
2 participants
@gopherbot @matloob