Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: Certificate no longer encodable using encoding/gob in Go1.22 [1.22 backport] #66273

Closed
gopherbot opened this issue Mar 12, 2024 · 3 comments
Closed

crypto/x509: Certificate no longer encodable using encoding/gob in Go1.22 [1.22 backport] #66273

gopherbot opened this issue Mar 12, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.22.2

Comments

@gopherbot
Copy link
Contributor

@rsc requested issue #65633 to be considered for backport to the next 1.22 minor release.

@gopherbot please backport go1.22
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 12, 2024
@gopherbot gopherbot mentioned this issue Mar 12, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.2 milestone Mar 12, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/571715 mentions this issue: [release-branch.go1.22] encoding/gob: make x509.Certificate marshalable again

@thanm
Copy link
Contributor

thanm commented Mar 27, 2024

Discussed in the release checkin meeting ->approved.

@thanm thanm added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 27, 2024
gopherbot pushed a commit that referenced this issue Mar 27, 2024
@rsc @thanm
[release-branch.go1.22] encoding/gob: make x509.Certificate marshalab…
0a5b33a 
…le again

The OID type is not exported data like most of the other x509 structs.
Using it in x509.Certificate made Certificate not gob-compatible anymore,
which breaks real-world code. As a temporary fix, make gob ignore
that field, making it work as well as it did in Go 1.21.

For Go 1.23, we anticipate adding a proper fix and removing the gob
workaround. See #65633 and #66249 for more details.

For #66249.
For #65633.
Fixes #66273.

Change-Id: Idd1431d15063b3009e15d0565cd3120b9fa13f61
Reviewed-on: https://go-review.googlesource.com/c/go/+/571095
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/571715
Reviewed-by: David Chase <drchase@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 0a5b33a to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.22.2
Development

No branches or pull requests
2 participants
@gopherbot @thanm