Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/trace: set the v2 tracer as the default tracer #66703

Closed
cagedmantis opened this issue Apr 5, 2024 · 4 comments
Closed

runtime/trace: set the v2 tracer as the default tracer #66703

cagedmantis opened this issue Apr 5, 2024 · 4 comments
Assignees
@cagedmantis
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.23

Comments

@cagedmantis
Copy link
Contributor

After the execution tracer overhaul described in #60773 is complete, we should make the v2 tracer the default version. This should involve:

  • Setting the v2 tracer as the default tracer.
  • Renaming all of the v2 files to be the default.
  • Removing the associated goexperiment flag.
  • Remove any lingering files that may no longer be in use.

@mknyszek
@cagedmantis cagedmantis added NeedsFix The path to resolution is known, but the work has not been done. compiler/runtime Issues related to the Go compiler and/or runtime. labels Apr 5, 2024
@cagedmantis cagedmantis added this to the Go1.23 milestone Apr 5, 2024
@cagedmantis cagedmantis self-assigned this Apr 5, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/576256 mentions this issue: runtime, cmd/trace: remove code paths that include v1 tracer

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/576257 mentions this issue: runtime: rename v2 execution tracer files

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/576258 mentions this issue: internal/goexperiment: remove the ExecTracer2 experiment

@mknyszek mknyszek moved this to In Progress in Go Compiler / Runtime Apr 10, 2024
gopherbot pushed a commit that referenced this issue Apr 15, 2024
@cagedmantis
runtime, cmd/trace: remove code paths that include v1 tracer
2c5849d 
This change makes the new execution tracer described in #60773, the
default tracer. This change attempts to make the smallest amount of
changes for a single CL.

Updates #66703
For #60773

Change-Id: I3742f3419c54f07d7c020ae5e1c18d29d8bcae6d
Reviewed-on: https://go-review.googlesource.com/c/go/+/576256
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit that referenced this issue Apr 15, 2024
@cagedmantis @gopherbot
runtime: rename v2 execution tracer files
7b10c49 
This change renames the v2 execution tracer files created as part of

Updates #66703
For #60773

Change-Id: I91bfdc08fec4ec68ff3a6e8b5c86f6f8bcae6e6d
Reviewed-on: https://go-review.googlesource.com/c/go/+/576257
Auto-Submit: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
gopherbot pushed a commit that referenced this issue Apr 15, 2024
@cagedmantis
internal/goexperiment: remove the ExecTracer2 experiment
55e4097 
This change removes the ExecTracer2 experiment flag. This flag was
created as part of the tracer overhaul described in #60773.

Updates #66703
For #60773

Change-Id: Ib95b9dd8bb68b48e7543c4d28d853c6a518438f6
Reviewed-on: https://go-review.googlesource.com/c/go/+/576258
Auto-Submit: Carlos Amedee <carlos@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@cagedmantis
Copy link
Contributor Author

This work has been completed.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagedmantis cagedmantis

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Compiler / Runtime
Status: Done
Milestone
Go1.23
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot