Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestPlatformVerifier failures on Windows due to broken connections [1.22 backport] #67352

Closed
gopherbot opened this issue May 14, 2024 · 4 comments
Closed

crypto/x509: TestPlatformVerifier failures on Windows due to broken connections [1.22 backport] #67352

gopherbot opened this issue May 14, 2024 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases Security Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22.4

Comments

@gopherbot
Copy link
Contributor

@rolandshoemaker requested issue #56791 to be considered for backport to the next 1.22 minor release.

@gopherbot please open backport issues for this. It's an incredibly noisy test which is currently only failing on the release branches. Those branches currently have the better tests enabled, so we should just backport https://go.dev/cl/548976 and remove these old broken ones to make the builders happy.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Security labels May 14, 2024
@gopherbot gopherbot mentioned this issue May 14, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.4 milestone May 14, 2024
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 14, 2024
@dmitshur
Copy link
Contributor

This is now approved for backporting. @rolandshoemaker Is it convenient for you to mail the backport CLs? Thanks.

@rolandshoemaker
Copy link
Member

Yes I can do that, thanks!

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/586235 mentions this issue: [release-branch.go1.22] crypto/x509: remove TestPlatformVerifierLegacy tests

@gopherbot
Copy link
Contributor Author

Closed by merging 185457d to release-branch.go1.22.

gopherbot pushed a commit that referenced this issue May 16, 2024
@rolandshoemaker @gopherbot
[release-branch.go1.22] crypto/x509: remove TestPlatformVerifierLegac…
185457d 
…y tests

They are no longer necessary, woohoo!

Updates #52108
Fixes #56791
Fixes #67352

Change-Id: I11a4c17162da4295309f74f2f8362bab0f506f78
Reviewed-on: https://go-review.googlesource.com/c/go/+/548976
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit c1828fb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/586235
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@KexyBiscuit KexyBiscuit mentioned this issue Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Security Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22.4
Development

No branches or pull requests
3 participants
@dmitshur @rolandshoemaker @gopherbot