Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/netip: unexpected behavior from Is methods for IPv4-mapped IPv6 addresses [CVE-2024-24790] [1.22 backport] #67682

Closed
gopherbot opened this issue May 28, 2024 · 2 comments
Closed

net/netip: unexpected behavior from Is methods for IPv4-mapped IPv6 addresses [CVE-2024-24790] [1.22 backport] #67682

gopherbot opened this issue May 28, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases release-blocker Security
Milestone
Go1.22.4

Comments

@gopherbot
Copy link
Contributor

@rolandshoemaker requested issue #67680 to be considered for backport to the next 1.22 minor release.

@gopherbot please open backport issues, this is a security issue.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Security labels May 28, 2024
@gopherbot gopherbot mentioned this issue May 28, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.4 milestone May 28, 2024
@cagedmantis cagedmantis added CherryPickApproved Used during the release process for point releases release-blocker labels May 30, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 30, 2024
@MadhavJivrajani MadhavJivrajani mentioned this issue May 30, 2024
Closed
45 tasks
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/590296 mentions this issue: [release-branch.go1.22] net/netip: check if address is v6 mapped in Is methods

gopherbot pushed a commit that referenced this issue Jun 4, 2024
@rolandshoemaker @gopherbot
[release-branch.go1.22] net/netip: check if address is v6 mapped in I…
12d5810 
…s methods

In all of the Is* methods, check if the address is a v6 mapped v4
address, and unmap it if so.

Thanks to Enze Wang of Alioth (@zer0yu) and Jianjun Chen of Zhongguancun
Lab (@chenjj) for reporting this issue.

Fixes #67680
Fixes #67682
Fixes CVE-2024-24790

Change-Id: I6bd03ca1a5d93a0b59027d861c84060967b265b0
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1460
Reviewed-by: Russ Cox <rsc@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
(cherry picked from commit f7f270c1621fdc7ee48e0487b2fac0356947d19b)
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1480
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/590296
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 12d5810 to release-branch.go1.22.

@mknyszek mknyszek changed the title security: fix CVE-2024-24790 [1.22 backport] net/netip: unexpected behavior from Is methods for IPv4-mapped IPv6 addresses [CVE-2024-24790] [1.22 backport] Jun 4, 2024
@akhilerm akhilerm mentioned this issue Jun 5, 2024
Merged
@reneleonhardt reneleonhardt mentioned this issue Jun 21, 2024
Closed
@KexyBiscuit KexyBiscuit mentioned this issue Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases release-blocker Security
Projects
None yet
Milestone
Go1.22.4
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot