encoding/xml: accepts XML with no space between attributes

[DemiMarie]

Go version

1.22.5 (this is from pkg.go.dev)

Output of go env in your module/workspace:

Whatever is on `pkg.go.dev` as of the filing of this issue

What did you do?

https://go.dev/play/p/_xXpPKU-YWQ

package main

import "encoding/xml"

func main() {
	err := xml.Unmarshal([]byte(`<a b="c" c="d"/>`), new(interface{}))
	if err != nil {
		panic("well-formed XML rejected")
	}
	err = xml.Unmarshal([]byte(`<a b="c"c="d"/>`), new(interface{}))
	if err == nil {
		panic("missing space before attribute name accepted")
	}
}

What did you see happen?

Unmarshaling the XML succeeds, even though there is a missing space between b="c" and c="d".

What did you expect to see?

Unmarshaling <a b="c"c="d"/> fails. libxml2 correctly rejects this.

[gabyhelp]

Related Issues and Documentation

• encoding/xml: does not reject non-space before the root element or after the end of the root element #68332
• encoding/xml: accepts various ill-formed XML #68293
• encoding/xml: mismatching namespace error misses a space char #49635 (closed)
• encoding/xml: does not reject multiple attributes with the same namespace URL and local part #68297
• encoding/xml: accepts invalid XML with multiple colons #20396 (closed)
• encoding/xml: Decoder does not reject xml-ProcInst preceeded by other data #65691
• encoding/xml: does not reject duplicate attribute names #68295
• encoding/xml: Marshalling change for namespace of XML-element without xml tag in corresponding go-struct in go 1.21+ #64166 (closed)
• encoding/xml: add whitespace normalization from spec #20614
• encoding/xml: encoding a start token with a namespace set in Name and Attr results in invalid XML #42807

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/609378 mentions this issue: encoding/xml: Require whitespace between attributes