-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: internal compiler error: 'foo.toStrings': value v2 still has 1 uses #68585
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
gabywins
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
gopherbot
added
the
compiler/runtime
Issues related to the Go compiler and/or runtime.
label
Jul 25, 2024
Likely duplicated of #65808 |
I just checked, it applies clean, and the test passes. And the fix itself is very low risk. |
Change https://go.dev/cl/601195 mentions this issue: |
seankhliao
added
the
NeedsFix
The path to resolution is known, but the work has not been done.
label
Jul 26, 2024
gopherbot
pushed a commit
that referenced
this issue
Jul 31, 2024
… to copyelim The problem was caused by faulty handling of unSSA-able operations on zero-sized data in expand calls, but there is no point to operations on zero-sized data. This CL adds a simplify step to the first place in SSA where all values are processed and replaces anything producing a 0-sized struct/array with the corresponding Struct/Array Make0 operation (of the appropriate type). I attempted not generating them in ssagen, but that was a larger change, and also had bugs. This is simple and obvious. The only question is whether it would be worthwhile to do it earlier (in numberlines or phielem). Fixes #68594. Fixes #68585. Change-Id: I0a596b3d272798015e7bb6b1a20411241759fe0e Reviewed-on: https://go-review.googlesource.com/c/go/+/568258 Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> (cherry picked from commit 6f5d774) Reviewed-on: https://go-review.googlesource.com/c/go/+/601195
Closing as duplicate of #65808. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler/runtime
Issues related to the Go compiler and/or runtime.
gabywins
NeedsFix
The path to resolution is known, but the work has not been done.
Go version
go version go1.22.5 linux/amd64
Output of
go env
in your module/workspace:What did you do?
Compile using the command
go build main.go
.https://go.dev/play/p/EkHQBeM63VJ
What did you see happen?
An internal compiler error occurred.
What did you expect to see?
Successful compilation of the program.
The text was updated successfully, but these errors were encountered: