Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: error in Go 1.23.0 with generics, type aliases and indexing [1.23 backport] #68905

Closed
gopherbot opened this issue Aug 15, 2024 · 2 comments
Closed

cmd/compile: error in Go 1.23.0 with generics, type aliases and indexing [1.23 backport] #68905

gopherbot opened this issue Aug 15, 2024 · 2 comments
Assignees
@timothy-king
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.23.1

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #68903 to be considered for backport to the next 1.23 minor release.

@gopherbot Please open a backport to the 1.23 release.

This appears to be a regression in the compiler.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 15, 2024
@gopherbot gopherbot mentioned this issue Aug 15, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 15, 2024
@gopherbot gopherbot added this to the Go1.23.1 milestone Aug 15, 2024
@timothy-king timothy-king mentioned this issue Aug 19, 2024
Closed
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/607635 mentions this issue: [release-branch.go1.23] go/types, types2: unalias tilde terms in underIs

@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Aug 28, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 28, 2024
gopherbot pushed a commit that referenced this issue Aug 28, 2024
@timothy-king @prattmic
[release-branch.go1.23] go/types, types2: unalias tilde terms in underIs
9625a7f 
Unalias the ~T terms during underIs. Before, if T was an alias
of U, it may pass T to the iteration function. The iterator
function expects an underlying type, under(U), to be passed.
This caused several bugs where underIs is used without
eventually taking the underlying type.

Fixes #68905

Change-Id: Ie8691d8dddaea00e1dcba94d17c0f1b021fc49a2
Reviewed-on: https://go-review.googlesource.com/c/go/+/606075
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
(cherry picked from commit 1a90dcd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/607635
@gopherbot
Copy link
Contributor Author

Closed by merging CL 607635 (commit 9625a7f) to release-branch.go1.23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timothy-king timothy-king

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.23.1
Development

No branches or pull requests
3 participants
@timothy-king @prattmic @gopherbot