-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: go build -asan may mis-parse gcc compiler version in a non-English environment #69221
Labels
FixPending
Issues that have a fix which has not yet been reviewed or submitted.
GoCommand
cmd/go
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Comments
Related Issues and Documentation
(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.) |
jokemanfire
added a commit
to jokemanfire/go
that referenced
this issue
Sep 3, 2024
Fixes golang#69221 work/init:compilerVersion support multi-language
jokemanfire
pushed a commit
to jokemanfire/go
that referenced
this issue
Sep 3, 2024
Fixes golang#69221 work/init:compilerVersion support multi-language
Change https://go.dev/cl/610215 mentions this issue: |
jokemanfire
pushed a commit
to jokemanfire/go
that referenced
this issue
Sep 4, 2024
Compiler's version will not work well if gcc output have different language. If gcc -v, it may not output like: 'gcc version xx.xx.x' Fixes golang#69221
dmitshur
changed the title
Get compilerVersion may not correct,if cc use Chinese
cmd/go: go build -asan may mis-parse gcc compiler version in a non-English environment
Sep 4, 2024
dmitshur
added
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
FixPending
Issues that have a fix which has not yet been reviewed or submitted.
labels
Sep 4, 2024
CC @matloob, @ianlancetaylor. |
jokemanfire
pushed a commit
to jokemanfire/go
that referenced
this issue
Sep 5, 2024
Compiler's version will not work well if gcc output have different language. If gcc -v, it may not output like: 'gcc version xx.xx.x' Fixes golang#69221
dmitshur
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FixPending
Issues that have a fix which has not yet been reviewed or submitted.
GoCommand
cmd/go
NeedsFix
The path to resolution is known, but the work has not been done.
Go version
go version go1.21.0 linux/amd64 (master branch also influence)
Output of
go env
in your module/workspace:What did you do?
when I use go build -asan.
What did you see happen?
it report "-asan is not supported with gcc compiler 0.0"
gcc -v looks like this:
gcc -v
What did you expect to see?
that's because compilerVersion , Use of regular expressions is
gcc version (\d+)\.(\d+)
but, it couldn't pattern with 'gcc 版本 8.4.1 20200928 'I think should change the regexp, if needed I would like to pull this pr.
The text was updated successfully, but these errors were encountered: