Skip to content

x/build/cmd/coordinator: older dashboard pages omit LUCI builders in detailed views (page 2, x/ repo commits) but don't make it apparent it's WAI #70314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
qmuntal opened this issue Nov 13, 2024 · 4 comments
Open

x/build/cmd/coordinator: older dashboard pages omit LUCI builders in detailed views (page 2, x/ repo commits) but don't make it apparent it's WAI #70314

qmuntal opened this issue Nov 13, 2024 · 4 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. Friction Nuisances that make good candidates for our "friction" fix-it weeks NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@qmuntal
Copy link
Member

qmuntal commented Nov 13, 2024 •
edited
Loading

What did you do?

Navigate to https://build.golang.org/?page=1&branch=master.

What did you see happen?

Only a small number of builders are displayed:

image

What did you expect to see?

All builders.
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@qmuntal qmuntal changed the title build: older build dashboard pages omit many builders x/build/app: older dashboard pages omit many builders Nov 13, 2024
@qmuntal qmuntal added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 13, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 13, 2024
@gopherbot gopherbot added this to the Unreleased milestone Nov 13, 2024
@qmuntal
Copy link
Member Author

qmuntal commented Jan 13, 2025

@dmitshur

@dmitshur dmitshur self-assigned this Jan 14, 2025
@dmitshur dmitshur moved this to In Progress in Go Release Jan 21, 2025
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Friction Nuisances that make good candidates for our "friction" fix-it weeks and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 21, 2025
@dmitshur dmitshur changed the title x/build/app: older dashboard pages omit many builders x/build/cmd/coordinator: older dashboard pages omit LUCI builders in detailed views (page 2, x/ repo commits) but don't make it apparent it's WAI Jan 24, 2025
@dmitshur
Copy link
Contributor

dmitshur commented Jan 24, 2025 •
edited
Loading

Thanks for reporting this.

The missing builders on those pages are all the new LUCI builders. In #65913 we provided limited support for displaying LUCI build results on build.golang.org, but that support applies only to the top-level page, not more detailed views (like page 2 onwards for main Go repo, or historical commits of each x/ repo).

We still have links that point to these detailed views, which is confusing. For now I'll send a change that makes those links point to appropriate views in LUCI UI where the builders can be viewed. We can also take advantage of the "by Go" views in the LUCI dashboard, something the legacy dashboard was known to have poor support for (see #28643).

Screenshot

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/644156 mentions this issue: cmd/coordinator: link to LUCI UI for non-top-level dashboard pages

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Jan 24, 2025
gopherbot pushed a commit to golang/build that referenced this issue Feb 3, 2025
@dmitshur @gopherbot
cmd/coordinator: link to LUCI UI for non-top-level dashboard pages
e76a69f 
The build.golang.org dashboard gained support to display build results
from LUCI, in addition to legacy builder results (go.dev/issue/65913),
but only for the default top-level view.

When visiting more detailed pages, like page 2 of commits for the main
Go repo, or detailed views for golang.org/x repos, no LUCI build results
are shown, which can be confusing. So, when displaying LUCI results
(i.e., the 'legacyonly' query parameter isn't used to hide them),
change links to detailed views on the top-level view to point to the
LUCI UI where results can in fact be viewed.

For golang/go#28643.
For golang/go#65913.
For golang/go#70314.

Change-Id: I3ebfba5bc6d0cd2e37d8e5fc1386843c6e298ce7
Reviewed-on: https://go-review.googlesource.com/c/build/+/644156
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. Friction Nuisances that make good candidates for our "friction" fix-it weeks NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: In Progress
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @qmuntal @gopherbot @gabyhelp