cmd/compile/internal/importer: flip enable alias to true [1.23 backport]

[xieyuschen]

This issue is created to request a backport at go1.23 to fix #70394. The issue doesn't exist in go1.24(master) as the code has refactored a bit before and fixed this issue.

go/src/cmd/compile/internal/importer/ureader.go

Line 34 in b0bbfb1

enableAlias: true,

The backport fix allows ureader to read exportdata with alias correctly and it doesn't affect the correctness of compile to construct exportdata for the following packages.

@timothy-king

[gopherbot]

Change https://go.dev/cl/629997 mentions this issue: [release-branch.go1.23] cmd/compile: enable alias for pkgReader

[timothy-king]

Thoughts for cherrypicking: Setting enableAlias: true, seems plausible. I would like to do more tests first though before weighing in on whether it is worth the risk.

[gopherbot]

Change https://go.dev/cl/631855 mentions this issue: [release-branch.go1.23] cmd/compile/internal/importer: enable aliases

[timothy-king]

My investigation makes me believe that this should be safe enough for 1.23. The CL to cherry pick would be https://go.dev/cl/631855.

[mvdan]

When could I expect a 1.23.x release with this fix? I was hoping that would be the case with 1.23.4, given that the patch was approved last week, but unfortunately I see it's not the case.

[timothy-king]

@mvdan The patch has been approved on gerrit, but the status on the issue is CherryPickCandidate. For it to go forward, its must be CherryPickApproved. See https://go.dev/wiki/MinorReleases. (Yes this can be confusing.)

[mvdan]

I see. Hopefully this can move along relatively quickly at this point, as I am unable to use alias tracking still.

[cagedmantis]

This change has been approved as it is a problem without a viable workaround.

[gopherbot]

Closed by merging CL 631855 (commit 69c8cfe) to release-branch.go1.23.

[mvdan]

Hi again - is there perhaps a chance that 1.23.5 with this backport will happen before the holidays?