Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-mode.el breaks when editing empty file #8

Closed
gopherbot opened this issue Nov 11, 2009 · 2 comments
Closed

go-mode.el breaks when editing empty file #8

gopherbot opened this issue Nov 11, 2009 · 2 comments

Comments

@gopherbot
Copy link
Contributor

by kballard:

When trying to switch to go-mode on an empty buffer, a Lisp error is raised:

Debugger entered--Lisp error: (args-out-of-range 0 1)
  remove-list-of-text-properties(1 0 (go-mode-cs go-mode-nesting))
  go-mode()
  ...
@rsc
Copy link
Contributor

rsc commented Nov 11, 2009

Comment 1:

This issue was closed by revision 022e3ae.

Status changed to Fixed.

Merged into issue #-.

aclements added a commit that referenced this issue Jan 8, 2015
This improves the printing of GC times to be both more human-friendly
and to provide enough information for the construction of MMU curves
and other statistics.  The new times look like:

GC: #8 72413852ns @143036695895725 pause=622900 maxpause=427037 goroutines=11 gomaxprocs=4
GC:     sweep term: 190584ns	   max=190584	total=275001	procs=4
GC:     scan:       260397ns	   max=260397	total=902666	procs=1
GC:     install wb: 5279ns	   max=5279	total=18642	procs=4
GC:     mark:       71530555ns	   max=71530555	total=186694660	procs=1
GC:     mark term:  427037ns	   max=427037	total=1691184	procs=4

This prints gomaxprocs and the number of procs used in each phase for
the benefit of analyzing mutator utilization during concurrent phases.
This also means the analysis doesn't have to hard-code which phases
are STW.

This prints the absolute start time only for the GC cycle.  The other
start times can be derived from the phase durations.  This declutters
the view for humans readers and doesn't pose any additional complexity
for machine readers.

This removes the confusing "cycle" terminology.  Instead, this places
the phase duration after the phase name and adds a "ns" unit, which
both makes it implicitly clear that this is the duration of that phase
and indicates the units of the times.

This adds a "GC:" prefix to all lines for easier identification.

Finally, this generally cleans up the code as well as the placement of
spaces in the output and adds print locking so the statistics blocks
are never interrupted by other prints.

Change-Id: Ifd056db83ed1b888de7dfa9a8fc5732b01ccc631
Reviewed-on: https://go-review.googlesource.com/2542
Reviewed-by: Rick Hudson <rlh@golang.org>
minux pushed a commit to minux/goios that referenced this issue Feb 27, 2015
liblink/asm7.c: add a little bit of helpful text to aide the reader of Optab
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@gopherbot
Copy link
Contributor Author

CL https://golang.org/cl/37025 mentions this issue.

tklauser pushed a commit to tklauser/go that referenced this issue May 8, 2019
Remove both FP and SB as concrete registers; they are purely
psuedo-registers.

FP offsets are handled by adding the current SP adjustment to the offset
of NAME_PARAM Addrs.

I am unsure of my arg and frame sizes in riscv_hello.s. It is not clear
to me if callers are supposed to leave room for return values in their
frame size or if callees are supposed to add them to their argument
size. The assembly in the runtime seems to be inconsistent.

Fixes golang#8

Change-Id: Ib79efb4fea8629f22461b4ebfc987bc8785a3ce3
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants