Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove Pull Request note in README.md #23752

Closed
wants to merge 1 commit into from
Closed

doc: remove Pull Request note in README.md #23752

wants to merge 1 commit into from

Conversation

andybons
Copy link
Member

@andybons andybons commented Feb 8, 2018

Since we now accept Pull Requests via GerritBot, this comment is obsolete.

@andybons
doc: remove Pull Request note in README.md
01818bd 
Since we now accept Pull Requests via GerritBot, this comment is obsolete.
@gopherbot gopherbot added the Documentation Issues describing a change to documentation. label Feb 8, 2018
@gopherbot
Copy link
Contributor

Hi! Thanks for the PR!

Unfortunately, the Go project doesn't use GitHub's Pull Requests,
so we can't accept your contribution this way.
We instead use a code review system called Gerrit.

The good news is, I'm here to help.

From here, you have two options:

  1. Read our Contribution Guidelines to learn how to send a change with Gerrit.
  2. Or, create an issue about the issue this PR addresses, so that someone else can fix it.

I'm going to close this Pull Request now.
Please don't be offended! :-)

Thanks again,

GopherBot (on behalf of the Go Team)

@gopherbot gopherbot closed this Feb 8, 2018
@davecheney
Copy link
Contributor

Oh the irony.

@andybons
Copy link
Member Author

andybons commented Feb 8, 2018

Let's try this again.

@andybons andybons reopened this Feb 8, 2018
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Feb 8, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: 01818bd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/go/+/92995 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/92995 mentions this issue: doc: remove Pull Request note in README.md

@gopherbot
Copy link
Contributor

Brad Fitzpatrick has posted review comments at golang.org/cl/92995.

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/92995 has been merged.

@gopherbot gopherbot closed this Feb 8, 2018
gopherbot pushed a commit that referenced this pull request Feb 8, 2018
@andybons
doc: remove Pull Request note in README.md
d814c2b 
Since we now accept Pull Requests via GerritBot, this comment is obsolete.

Change-Id: I0de8ecff7d1f146320a52f143e65068f8adbeaa6
GitHub-Last-Rev: 01818bd
GitHub-Pull-Request: #23752
Reviewed-on: https://go-review.googlesource.com/92995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz
Copy link
Contributor

bradfitz commented Feb 8, 2018

Brad Fitzpatrick has posted review comments at golang.org/cl/92995.

Actually I didn't write a single English word. I just voted +2. Ideally we'd revise this message to be more specific. Low priority.

@hanwen
Copy link
Contributor

hanwen commented Feb 9, 2018

nice. Is this also powered off your superduper-emailpubsub?

@bradfitz
Copy link
Contributor

bradfitz commented Feb 9, 2018

@hanwen, yes, it uses https://maintner.golang.org/ and https://pubsubhelper.golang.org. But of course there's plenty of code on top of that. See https://github.com/golang/build/tree/master/cmd/gerritbot

gopherbot pushed a commit to golang/build that referenced this pull request Feb 9, 2018
@andybons
cmd/gopherbot: ignore GitHub PRs when updating issues
a6a9ae9 
Otherwise you get something like
golang/go#23752 (comment)

Update golang/go#18517

Change-Id: I5298f1e34738a4f6faa8b829546bf880a237043d
Reviewed-on: https://go-review.googlesource.com/93015
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@andybons andybons deleted the andybons-patch-2 branch February 9, 2018 05:06
@amazingandyyy
Copy link

this is epic

amazingandyyy
amazingandyyy reviewed Feb 9, 2018
View reviewed changes
README.md
@@ -36,10 +36,9 @@ Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines:
https://golang.org/doc/contribute.html

Note that the Go project does not use GitHub pull requests, and that
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not!

e-nikolov pushed a commit to e-nikolov/json that referenced this pull request Nov 25, 2021
@andybons
doc: remove Pull Request note in README.md
8c03a7c 
Since we now accept Pull Requests via GerritBot, this comment is obsolete.

Change-Id: I0de8ecff7d1f146320a52f143e65068f8adbeaa6
GitHub-Last-Rev: 01818bdf7a8361efde427a872b813f2e8510cef7
GitHub-Pull-Request: golang/go#23752
Reviewed-on: https://go-review.googlesource.com/92995
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amazingandyyy amazingandyyy amazingandyyy left review comments

Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. Documentation Issues describing a change to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@andybons @gopherbot @davecheney @bradfitz @hanwen @amazingandyyy @googlebot