path/filepath: use a temp dir in path_test.go #24238
Conversation
googlebot
added
the
cla: yes
|
This PR (HEAD: 5083e7e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/98517 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit Bot: Uploaded patch set 2: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Mostyn Bramley-Moore: Patch Set 2: WiP, I'm trying to figure out how to make this test use absolute paths (I'm not sure sure if this makes sense), to avoid the os.Chdir call. If that turns out to be a no-go, then the tree var does not need to be local. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
This PR (HEAD: 6ea846c) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/98517 to see it. Tip: You can toggle comments from me using the |
|
Message from Andrew Bonventre: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
This PR (HEAD: 62d17f3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/98517 to see it. Tip: You can toggle comments from me using the |
|
Message from Gerrit Bot: Uploaded patch set 4: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Gerrit Bot: Uploaded patch set 5: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Mostyn Bramley-Moore: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Brad Fitzpatrick: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Gobot Gobot: Patch Set 5: TryBots beginning. Status page: https://farmer.golang.org/try?commit=090843b7 Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Gobot Gobot: Patch Set 5: Build is still in progress... Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Gobot Gobot: Patch Set 5: TryBot-Result-1 2 of 17 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Mostyn Bramley-Moore: Patch Set 5: These windows build failures look strange, but I don't have access to a windows machine to debug locally- is it OK for me to upload some diagnostic changes here? And if so, will the trybots automatically run on the new patchset? Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Giovanni Bajo: Patch Set 5:
Sure go ahead. We'll monitor and trigger trybots. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
We should avoid writing temp files to GOROOT, since it might be readonly. Fixes golang#23881 Change-Id: I500ca0e0944b6053fd8fd2879ff88f5636424dab
|
This PR (HEAD: de0211d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/98517 to see it. Tip: You can toggle comments from me using the |
|
Message from Mostyn Bramley-Moore: Patch Set 6: Reverted to the os.Chdir version. I think the problem with patchset 5 was pre-existing cleanup at the bottom of the TestWalk function which tried to delete too much after i prepended paths to 'tree'. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Giovanni Bajo: Patch Set 6: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Gobot Gobot: Patch Set 6: TryBots beginning. Status page: https://farmer.golang.org/try?commit=de461bac Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Gobot Gobot: Patch Set 6: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
Message from Brad Fitzpatrick: Patch Set 6: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/98517. |
|
This PR is being closed because golang.org/cl/98517 has been merged. |
We should avoid writing temp files to GOROOT, since it might be readonly. Fixes #23881 Change-Id: Iaa38ec404b303f0cf27fdfb7daf1ddd60fd5d1c9 GitHub-Last-Rev: de0211d GitHub-Pull-Request: #24238 Reviewed-on: https://go-review.googlesource.com/98517 Run-TryBot: Giovanni Bajo <rasky@develer.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
We should avoid writing temp files to GOROOT, since it might be readonly.
Fixes #23881