Skip to content

encoding/json: document the unmarshalling of missing json fields #28735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

encoding/json: document the unmarshalling of missing json fields #28735

wants to merge 2 commits into from

Conversation

hellozee
Copy link
Contributor

The existing documentation misses covering what will happen if JSON
data with missing fields is unmarshalled, so a line is added to the
documentation of json.Unmarshall() mentioning the consequences of
unmarshalling JSON fields.

Fixes #27172

@hellozee
encoding/json: document the unmarshalling of missing json fields
dc2b05c 
The existing documentation misses to cover what will happen if json
data with missing fields is unmarshalled, so a line is added to the
documentation of json.Unmarshall() mentioning the consequences of
unmarshalling json fields.

Fixes #27172
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 12, 2018
@gopherbot
Copy link
Contributor

This PR (HEAD: dc2b05c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/148834 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

AnikHasibul
AnikHasibul approved these changes Nov 13, 2018
View reviewed changes
Copy link

@AnikHasibul AnikHasibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 1: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/148834.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 3b75299) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/148834 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Andrew Bonventre:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/148834.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 2: Code-Review-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/148834.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 2 times, most recently from 53bd915 to 6139019 Compare October 3, 2019 21:09
@gopherbot gopherbot force-pushed the master branch 6 times, most recently from 4a7ed1f to 0f992b9 Compare November 5, 2019 02:57
@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 2: Code-Review-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/148834.
After addressing review feedback, remember to publish your drafts!

@heschi heschi closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnikHasibul AnikHasibul AnikHasibul approved these changes

Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encoding/json: clarify merge semantics of Unmarshal
5 participants
@hellozee @gopherbot @AnikHasibul @googlebot @heschi