cmd/go,cmd/link: Adds shared linking support for FreeBSD/amd64

[kolbycrouch]

Fixes #29715

[gopherbot]

This PR (HEAD: 7107014) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/157682 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/157682.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Brad Fitzpatrick:

Patch Set 1:

(1 comment)

This is all that's required?

Aren't there tests to enable too?

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/157682.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 1:

You also need to change (*tester).supportedBuildMode in cmd/dist/test.go.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/157682.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Kolby Crouch:

Patch Set 1:

Patch Set 1:

You also need to change (*tester).supportedBuildMode in cmd/dist/test.go.

Ah sorry about that. I didn't even think to look for a test case.

Should I just make a new pull request with this commit + the change in cmd/dist/test.go?

Sorry for the noob mistakes. First time contributing to go, and first time dealing with Gerrit.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/157682.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 1:

You also need to change (*tester).supportedBuildMode in cmd/dist/test.go.

Ah sorry about that. I didn't even think to look for a test case.

Should I just make a new pull request with this commit + the change in cmd/dist/test.go?

Sorry for the noob mistakes. First time contributing to go, and first time dealing with Gerrit.

You should be able to add the change to cmd/dist/test.go to this change. You shouldn't need to create a new change. Though you can create a new change and close this one if that is easier.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/157682.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/157682.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Kolby Crouch:

Patch Set 1:

Patch Set 1:

You also need to change (*tester).supportedBuildMode in cmd/dist/test.go.

Ah sorry about that. I didn't even think to look for a test case.

Should I just make a new pull request with this commit + the change in cmd/dist/test.go?

Sorry for the noob mistakes. First time contributing to go, and first time dealing with Gerrit.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/157682.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Ian Lance Taylor:

Patch Set 1:

You also need to change (*tester).supportedBuildMode in cmd/dist/test.go.

Ah sorry about that. I didn't even think to look for a test case.

Should I just make a new pull request with this commit + the change in cmd/dist/test.go?

Sorry for the noob mistakes. First time contributing to go, and first time dealing with Gerrit.

You should be able to add the change to cmd/dist/test.go to this change. You shouldn't need to create a new change. Though you can create a new change and close this one if that is easier.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/157682.
After addressing review feedback, remember to publish your drafts!