-
Notifications
You must be signed in to change notification settings - Fork 18k
crypto/tls: Expose maps for cipher suite IDs/names #30326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
03eafd8
to
f01fc49
Compare
This PR (HEAD: f01fc49) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/163119 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/163119. |
These are utility functions that allow you to get maps that translate from Cipher Suite names towards IDs and vice versa. The main purpose of this is to be able to easily parse such configurations for HTTP(s) servers without much boiler plate code. Fixes: golang#30325
f01fc49
to
6d13a8f
Compare
This PR (HEAD: 6d13a8f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/163119 to see it. Tip: You can toggle comments from me using the |
Thank you @JAORMX for this pull request, Having this change would be awesome. I often have problems in GO where some go packages holds some information I'd like to access, but I can't because its private and there is no way araound. Okay, technically, in this case the data is accessible, but not in an dynamic way. I need to know the constants and i cannot just query them. This really sucks. From a builders point of view I understand, that some information is not necessary and can be unknown. But i do use Go for testing (respectively, building security checks), and such information is elemntary to me. I have a similar problem with the SSH package. It holds information about what cipher suites are supported by a remote server, but I can't access it ^^ |
@noneymous thanks for checking this out! Feel free to jump in #30325 where the discussion about this is happening. |
These are utility functions that allow you to get maps that translate from Cipher Suite names towards IDs and vice versa.
The main purpose of this is to be able to easily parse such configurations for HTTP(s) servers without much boiler plate code.
Fixes: #30325