Skip to content

crypto/tls: Expose CipherSuite structure and add names #30654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

crypto/tls: Expose CipherSuite structure and add names #30654

wants to merge 2 commits into from

Conversation

JAORMX
Copy link

@JAORMX JAORMX commented Mar 7, 2019

This change exposes the CipherSuite structure, so folks can actually use
it in their code-bases. It also exposes the needed functions to get the
cipher suite both by name and by ID.

The "name" of the cipher suite was added to the struct.

Fixes: #30325

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 7, 2019
@JAORMX JAORMX mentioned this pull request Mar 7, 2019
Closed
@JAORMX JAORMX force-pushed the cipher-suite-name branch from f53013c to 8b9a096 Compare March 7, 2019 10:15
@gopherbot
Copy link
Contributor

This PR (HEAD: 8b9a096) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/165957 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@JAORMX JAORMX force-pushed the cipher-suite-name branch from 8b9a096 to 45195f7 Compare March 7, 2019 13:59
@gopherbot
Copy link
Contributor

This PR (HEAD: 45195f7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/165957 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 2:

Hey! could you check this commit out?

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 2:

hey! could you check this patch if you have time?

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@JAORMX JAORMX force-pushed the cipher-suite-name branch from 45195f7 to cf9f7b4 Compare March 11, 2019 09:50
@gopherbot
Copy link
Contributor

This PR (HEAD: cf9f7b4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/165957 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@JAORMX JAORMX force-pushed the cipher-suite-name branch from cf9f7b4 to 5455847 Compare March 13, 2019 13:11
@gopherbot
Copy link
Contributor

This PR (HEAD: 5455847) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/165957 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 4: Run-TryBot+1 Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=6fa6480c

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

Build is still in progress...
This change failed on openbsd-amd64-64:
See https://storage.googleapis.com/go-build-log/6fa6480c/openbsd-amd64-64_aab2217e.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result-1

19 of 19 TryBots failed:
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/6fa6480c/openbsd-amd64-64_aab2217e.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/6fa6480c/freebsd-amd64-12_0_837c1091.log
Failed on misc-compile-nacl: https://storage.googleapis.com/go-build-log/6fa6480c/misc-compile-nacl_2c4eecec.log
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/6fa6480c/misc-vet-vetall_a32e35a4.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/6fa6480c/linux-amd64_2ff90593.log
Failed on misc-compile-plan9: https://storage.googleapis.com/go-build-log/6fa6480c/misc-compile-plan9_2ecaefb1.log
Failed on misc-compile-freebsd: https://storage.googleapis.com/go-build-log/6fa6480c/misc-compile-freebsd_5ad26266.log
Failed on misc-compile-netbsd: https://storage.googleapis.com/go-build-log/6fa6480c/misc-compile-netbsd_eaaf46f5.log
Failed on misc-compile: https://storage.googleapis.com/go-build-log/6fa6480c/misc-compile_c68791de.log
Failed on misc-compile-ppc: https://storage.googleapis.com/go-build-log/6fa6480c/misc-compile-ppc_122f4519.log
Failed on nacl-amd64p32: https://storage.googleapis.com/go-build-log/6fa6480c/nacl-amd64p32_09ce314e.log
Failed on misc-compile-mips: https://storage.googleapis.com/go-build-log/6fa6480c/misc-compile-mips_936aa49f.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/6fa6480c/linux-amd64-race_818b3317.log
Failed on misc-compile-openbsd: https://storage.googleapis.com/go-build-log/6fa6480c/misc-compile-openbsd_a20047d8.log
Failed on js-wasm: https://storage.googleapis.com/go-build-log/6fa6480c/js-wasm_63446de5.log
Failed on nacl-386: https://storage.googleapis.com/go-build-log/6fa6480c/nacl-386_81f960e5.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/6fa6480c/linux-386_2445713e.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/6fa6480c/windows-amd64-2016_daca39e4.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/6fa6480c/windows-386-2008_b83a5b64.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@JAORMX JAORMX force-pushed the cipher-suite-name branch from 5455847 to 7d58dd0 Compare March 13, 2019 14:42
@gopherbot
Copy link
Contributor

This PR (HEAD: 7d58dd0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/165957 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 5:

I'm in the process of pushing a subsequent patch fixing some issues.

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

JAORMX added 2 commits March 13, 2019 17:11
@JAORMX
crypto/tls: Expose CipherSuite structure and add names
44d2f73 
This change exposes the CipherSuite structure, so folks can actually use
it in their code-bases. It also exposes the needed functions to get the
cipher suite both by name and by ID.

The "name" of the cipher suite was added to the struct.

Fixes: golang#30325
@JAORMX
Expose CipherSuite flags via Is[..] functions
292d7fe 
This creates several functions that expose whether the relevant flags
for the cipher suites are enabled or not.
@JAORMX JAORMX force-pushed the cipher-suite-name branch from 7d58dd0 to 292d7fe Compare March 13, 2019 15:15
@gopherbot
Copy link
Contributor

This PR (HEAD: 292d7fe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/165957 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 6:

Alright, I made this patch less invasive and the compile issues (sorry about those). Now it should be ready for review.

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 6:

Patch Set 6:

Alright, I made this patch less invasive and the compile issues (sorry about those). Now it should be ready for review.

  • and I fixed the compile issues

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 6: Run-TryBot+1 Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5984d9f8

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 6: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Juan Antonio Osorio:

Patch Set 6:

Any chance of getting a review for this? who else should we add to the reviewers list?

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 6:

Patch Set 6:

Any chance of getting a review for this? who else should we add to the reviewers list?

Filippo is the appropriate code owner as far as I am aware.
(He is also kind of subject to a perpetual firehose of crypto CLs, unfortunately.)

Please don’t reply on this GitHub thread. Visit golang.org/cl/165957.
After addressing review feedback, remember to publish your drafts!

@JAORMX JAORMX closed this Aug 28, 2019
@JAORMX JAORMX deleted the cipher-suite-name branch August 28, 2019 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: crypto/tls: Expose maps for cipher suite IDs/names
3 participants
@JAORMX @gopherbot @googlebot