Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: remove --first-parent for git tag discovery #31674

Closed
wants to merge 1 commit into from

Conversation

saschagrunert
Copy link

This commit fixes an invalid last tag retrieval for go modules by
including git tag from merge branches.

Fixes #31673

This commit fixes an invalid last tag retrieval for go modules by
including git tag from merge branches.

Fixes golang#31673
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Apr 25, 2019
@saschagrunert
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Apr 25, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 0c0e484) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/173667 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/173667.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Pontus Leitzler:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/173667.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Sascha Grunert:

Patch Set 1:

Patch Set 1:

(1 comment)

It depends on the release strategy of the related project. If the release branch gets merged back then this fix works as intended. If the project does not merge back the release branch then the tags won't be considered. This is out of scope of this fix and would imply further changes.


Please don’t reply on this GitHub thread. Visit golang.org/cl/173667.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Sascha Grunert:

Patch Set 1:

Patch Set 1:

(1 comment)

I mean we could also choose the very latest tag by checking all branches like this:

git describe --tags $(git rev-list --tags --max-count=1)


Please don’t reply on this GitHub thread. Visit golang.org/cl/173667.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from thepudds:

Patch Set 1:

This is not a comment on any of the proposed approaches, but just wanted to make a quick general comment that elsewhere the go tool tries to be careful about what versions it pulls in. See for example
#27043 (comment) or #27191 (comment).


Please don’t reply on this GitHub thread. Visit golang.org/cl/173667.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jay Conrod:

Patch Set 1:

Thanks for reporting this issue and working on a fix. We ended up merging CL 174061 to solve this (thanks Pontus Leitzler and thepudds!).


Please don’t reply on this GitHub thread. Visit golang.org/cl/173667.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/173667 has been abandoned.

Issue resolved by CL 174061

@gopherbot gopherbot closed this May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/go: Improve module tag discovery
3 participants