-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: remove --first-parent for git tag discovery #31674
Conversation
This commit fixes an invalid last tag retrieval for go modules by including git tag from merge branches. Fixes golang#31673
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 0c0e484) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/173667 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/173667. |
Message from Pontus Leitzler: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/173667. |
Message from Sascha Grunert: Patch Set 1:
It depends on the release strategy of the related project. If the release branch gets merged back then this fix works as intended. If the project does not merge back the release branch then the tags won't be considered. This is out of scope of this fix and would imply further changes. Please don’t reply on this GitHub thread. Visit golang.org/cl/173667. |
Message from Sascha Grunert: Patch Set 1:
I mean we could also choose the very latest tag by checking all branches like this: git describe --tags $(git rev-list --tags --max-count=1) Please don’t reply on this GitHub thread. Visit golang.org/cl/173667. |
Message from thepudds: Patch Set 1: This is not a comment on any of the proposed approaches, but just wanted to make a quick general comment that elsewhere the go tool tries to be careful about what versions it pulls in. See for example Please don’t reply on this GitHub thread. Visit golang.org/cl/173667. |
Message from Jay Conrod: Patch Set 1: Thanks for reporting this issue and working on a fix. We ended up merging CL 174061 to solve this (thanks Pontus Leitzler and thepudds!). Please don’t reply on this GitHub thread. Visit golang.org/cl/173667. |
This PR is being closed because golang.org/cl/173667 has been abandoned. Issue resolved by CL 174061 |
This commit fixes an invalid last tag retrieval for go modules by
including git tag from merge branches.
Fixes #31673