Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/json: validate strings when decoding into Number #34272

Closed
wants to merge 1 commit into from
Closed

encoding/json: validate strings when decoding into Number #34272

wants to merge 1 commit into from

Conversation

breml
Copy link
Contributor

@breml breml commented Sep 12, 2019 •
edited
Loading

Unmarshaling a string into a json.Number should first check that the string is a valid Number.
If not, we should fail without decoding it.

Fixes #14702

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 12, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: c34066e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/195045 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Lucas Bremgartner:

Patch Set 1:

I hope, it is ok to add you as reviewer on this one as well.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195045.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 1: Run-TryBot+1

(4 comments)

I hope, it is ok to add you as reviewer on this one as well.

Sure! Happy to review json CLs.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195045.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=058ee93d

Please don’t reply on this GitHub thread. Visit golang.org/cl/195045.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195045.
After addressing review feedback, remember to publish your drafts!

@breml breml changed the title encoding/json: fix unmarshal invalid json.Number encoding/json: validate strings when decoding into Number Sep 16, 2019
@breml
encoding/json: validate strings when decoding into Number
fe69bb6 
Unmarshaling a string into a json.Number should first check that
the string is a valid Number.
If not, we should fail without decoding it.

Fixes golang#14702
@breml breml force-pushed the fix-unmarshal-json-number branch from c34066e to fe69bb6 Compare September 16, 2019 19:45
@gopherbot
Copy link
Contributor

This PR (HEAD: fe69bb6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/195045 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Lucas Bremgartner:

Patch Set 3:

(4 comments)

Thanks for the review, I followed your recommendations.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195045.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Daniel Martí:

Patch Set 4: Run-TryBot+1 Code-Review+2

Thanks, much better!

Please don’t reply on this GitHub thread. Visit golang.org/cl/195045.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=4db9d9ad

Please don’t reply on this GitHub thread. Visit golang.org/cl/195045.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 4: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/195045.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 16, 2019
@breml @mvdan
encoding/json: validate strings when decoding into Number
c1000c5 
Unmarshaling a string into a json.Number should first check that the string is a valid Number.
If not, we should fail without decoding it.

Fixes #14702

Change-Id: I286178e93df74ad63c0a852c3f3489577072cf47
GitHub-Last-Rev: fe69bb6
GitHub-Pull-Request: #34272
Reviewed-on: https://go-review.googlesource.com/c/go/+/195045
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/195045 has been merged.

@gopherbot gopherbot closed this Sep 16, 2019
q3k pushed a commit to q3k/cursedjson that referenced this pull request Sep 26, 2019
@breml @mvdan
encoding/json: validate strings when decoding into Number
ed47705 
Unmarshaling a string into a json.Number should first check that the string is a valid Number.
If not, we should fail without decoding it.

Fixes #14702

Change-Id: I286178e93df74ad63c0a852c3f3489577072cf47
GitHub-Last-Rev: fe69bb68eed06d056639f440d2daf4bb7c99013b
GitHub-Pull-Request: golang/go#34272
Reviewed-on: https://go-review.googlesource.com/c/go/+/195045
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@knqyf263 knqyf263 mentioned this pull request Mar 31, 2020
Closed
e-nikolov pushed a commit to e-nikolov/json that referenced this pull request Nov 25, 2021
@breml @mvdan
encoding/json: validate strings when decoding into Number
7695e42 
Unmarshaling a string into a json.Number should first check that the string is a valid Number.
If not, we should fail without decoding it.

Fixes #14702

Change-Id: I286178e93df74ad63c0a852c3f3489577072cf47
GitHub-Last-Rev: fe69bb68eed06d056639f440d2daf4bb7c99013b
GitHub-Pull-Request: golang/go#34272
Reviewed-on: https://go-review.googlesource.com/c/go/+/195045
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
e-nikolov pushed a commit to e-nikolov/json that referenced this pull request Nov 25, 2021
@breml @mvdan
encoding/json: validate strings when decoding into Number
e652a91 
Unmarshaling a string into a json.Number should first check that the string is a valid Number.
If not, we should fail without decoding it.

Fixes #14702

Change-Id: I286178e93df74ad63c0a852c3f3489577072cf47
GitHub-Last-Rev: fe69bb68eed06d056639f440d2daf4bb7c99013b
GitHub-Pull-Request: golang/go#34272
Reviewed-on: https://go-review.googlesource.com/c/go/+/195045
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
e-nikolov pushed a commit to e-nikolov/json that referenced this pull request Nov 25, 2021
@breml @mvdan
encoding/json: validate strings when decoding into Number
8d76c56 
Unmarshaling a string into a json.Number should first check that the string is a valid Number.
If not, we should fail without decoding it.

Fixes #14702

Change-Id: I286178e93df74ad63c0a852c3f3489577072cf47
GitHub-Last-Rev: fe69bb68eed06d056639f440d2daf4bb7c99013b
GitHub-Pull-Request: golang/go#34272
Reviewed-on: https://go-review.googlesource.com/c/go/+/195045
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encoding/json: Unmarshal into struct field or a map does not validate invalid json.Number
3 participants
@breml @gopherbot @googlebot