crypto/elliptic: implement unmarshal for compressed format #35110

im-kulikov · 2019-10-23T13:17:27Z

First byte can be 0x2 or 0x3 (compressed form).
To unmarshal used formula y² = x³ - 3x + b.

gopherbot · 2019-10-23T13:20:25Z

This PR (HEAD: b46a8f8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/202819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-23T13:27:38Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202819.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-23T17:56:04Z

This PR (HEAD: d9a339d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/202819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-24T10:23:47Z

This PR (HEAD: a158b95) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/202819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

im-kulikov · 2019-11-15T11:25:07Z

@dvyukov I believe this is quite useful change, could you please suggest what should be changed in order to merge this request? Thanks.

dvyukov · 2019-11-15T12:59:37Z

@dvyukov I believe this is quite useful change, could you please suggest what should be changed in order to merge this request? Thanks.

This should answer your questions:
https://go-review.googlesource.com/c/go/+/202819/3#message-f07276cc31f521e20bb5c68f910b8de8c4de4580

im-kulikov · 2019-11-15T13:17:01Z

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged.

@dvyukov oh, it's my mistake, thanks.

gopherbot · 2019-11-18T10:47:38Z

This PR (HEAD: bfab7bc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/202819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-02-13T12:42:58Z

This PR (HEAD: ea579f5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/202819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

First byte can be 0x2 or 0x3 (compressed form). To unmarshal used formula y² = x³ - 3x + b. Reuse code from `IsOnCurve`. closes golang#34105 issue

gopherbot · 2020-02-13T12:55:15Z

This PR (HEAD: 9b38b0a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/202819 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

im-kulikov · 2020-03-10T03:09:08Z

Any updates?

gopherbot · 2020-03-20T18:46:59Z

Message from Katie Hockman:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/202819.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-20T18:47:00Z

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=ec8e7ea0

Please don’t reply on this GitHub thread. Visit golang.org/cl/202819.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-20T19:13:26Z

Message from Gobot Gobot:

Patch Set 6: TryBot-Result-1

1 of 20 TryBots failed:
Failed on (x/tools) linux-amd64: https://storage.googleapis.com/go-build-log/ec8e7ea0/linux-amd64_b250a94e.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202819.
After addressing review feedback, remember to publish your drafts!

im-kulikov · 2020-03-22T03:10:32Z

As I see, failed in another part (go mod)

im-kulikov · 2020-04-16T14:17:55Z

any updates?

gopherbot · 2020-05-07T07:07:18Z

Message from Filippo Valsorda:

Patch Set 6:

(7 comments)

Sorry for the review lag. The tree is almost frozen, but if you have time to address the comments today (on Thursday) it can still land in Go 1.15.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202819.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-07T07:29:12Z

Message from Gobot Gobot:

Patch Set 6: TryBot-Result-1

1 of 20 TryBots failed:
Failed on (x/tools) linux-amd64: https://storage.googleapis.com/go-build-log/ec8e7ea0/linux-amd64_80b9385a.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/202819.
After addressing review feedback, remember to publish your drafts!

FiloSottile · 2020-05-07T22:46:22Z

Closing the PR hoping gerritbot will then let me make changes to it in Gerrit, so I can land it today.

Fixes #34105 Co-authored-by: Filippo Valsorda <filippo@golang.org> Change-Id: I3470343ec9ce9a0bd5593a04d3ba5816b75d3332 GitHub-Last-Rev: 9b38b0a GitHub-Pull-Request: #35110 Reviewed-on: https://go-review.googlesource.com/c/go/+/202819 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>

Fixes #34105 Co-authored-by: Filippo Valsorda <filippo@golang.org> Change-Id: I3470343ec9ce9a0bd5593a04d3ba5816b75d3332 GitHub-Last-Rev: 9b38b0a7f8cef7f001fe9126a1cfcb4990f7b996 GitHub-Pull-Request: golang/go#35110 Reviewed-on: https://go-review.googlesource.com/c/go/+/202819 Run-TryBot: Filippo Valsorda <filippo@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Filippo Valsorda <filippo@golang.org>

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 23, 2019

im-kulikov force-pushed the unmarshal_compressed_elliptic_pubilc_key branch from b46a8f8 to d9a339d Compare October 23, 2019 17:55

im-kulikov force-pushed the unmarshal_compressed_elliptic_pubilc_key branch from d9a339d to a158b95 Compare October 24, 2019 10:22

im-kulikov force-pushed the unmarshal_compressed_elliptic_pubilc_key branch from a158b95 to bfab7bc Compare November 18, 2019 10:46

im-kulikov force-pushed the unmarshal_compressed_elliptic_pubilc_key branch from bfab7bc to ea579f5 Compare February 13, 2020 12:42

crypto/elliptic: Implement marshal / unmarshal for compressed format

9b38b0a

First byte can be 0x2 or 0x3 (compressed form). To unmarshal used formula y² = x³ - 3x + b. Reuse code from `IsOnCurve`. closes golang#34105 issue

im-kulikov force-pushed the unmarshal_compressed_elliptic_pubilc_key branch from ea579f5 to 9b38b0a Compare February 13, 2020 12:54

FiloSottile closed this May 7, 2020

im-kulikov deleted the unmarshal_compressed_elliptic_pubilc_key branch May 13, 2020 10:29

gdbelvin mentioned this pull request May 21, 2020

Simplify ECC CompressedMarshal / Unmarshal google/draft-irtf-cfrg-vrf#5

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

crypto/elliptic: implement unmarshal for compressed format #35110

crypto/elliptic: implement unmarshal for compressed format #35110

im-kulikov commented Oct 23, 2019

gopherbot commented Oct 23, 2019

gopherbot commented Oct 23, 2019

gopherbot commented Oct 23, 2019

gopherbot commented Oct 24, 2019

im-kulikov commented Nov 15, 2019

dvyukov commented Nov 15, 2019

im-kulikov commented Nov 15, 2019 •

edited

Loading

gopherbot commented Nov 18, 2019

gopherbot commented Feb 13, 2020

gopherbot commented Feb 13, 2020

im-kulikov commented Mar 10, 2020

gopherbot commented Mar 20, 2020

gopherbot commented Mar 20, 2020

gopherbot commented Mar 20, 2020

im-kulikov commented Mar 22, 2020

im-kulikov commented Apr 16, 2020

gopherbot commented May 7, 2020

gopherbot commented May 7, 2020

FiloSottile commented May 7, 2020

crypto/elliptic: implement unmarshal for compressed format #35110

crypto/elliptic: implement unmarshal for compressed format #35110

Conversation

im-kulikov commented Oct 23, 2019

gopherbot commented Oct 23, 2019

gopherbot commented Oct 23, 2019

gopherbot commented Oct 23, 2019

gopherbot commented Oct 24, 2019

im-kulikov commented Nov 15, 2019

dvyukov commented Nov 15, 2019

im-kulikov commented Nov 15, 2019 • edited Loading

gopherbot commented Nov 18, 2019

gopherbot commented Feb 13, 2020

gopherbot commented Feb 13, 2020

im-kulikov commented Mar 10, 2020

gopherbot commented Mar 20, 2020

gopherbot commented Mar 20, 2020

gopherbot commented Mar 20, 2020

im-kulikov commented Mar 22, 2020

im-kulikov commented Apr 16, 2020

gopherbot commented May 7, 2020

gopherbot commented May 7, 2020

FiloSottile commented May 7, 2020

im-kulikov commented Nov 15, 2019 •

edited

Loading