Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: add RevocationList and CreateRevocationList #36945

Closed
wants to merge 10 commits into from
Closed

crypto/x509: add RevocationList and CreateRevocationList #36945

wants to merge 10 commits into from

Commits on Jan 31, 2020

  1. crypto/x509: add RFC 5280/X509v2 compliant CRL generation function 

    The existing Certificate.CreateCRL method generates non-conformant CRLs and as
such cannot be used for implementations that require standards compliance. This
change implements a new top level method, CreateCRL, which generates compliant
CRLs, and offers an extensible API if any extensions/fields need to be
supported in the future.

Fixes golang#35428

Change-Id: I06ef833cb860077b2d42c1bb262a72c3e918aa0d
    Roland Shoemaker committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    55804f0 View commit details
    Browse the repository at this point in the history

  2. Fix CreateCRL comment 

    Change-Id: I2f00afbd80cb9d30ebdca338a9b812359c762c3f
    Roland Shoemaker committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    1da2356 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2020

  1. Change Number to big.Int and Extension to ExtraExtensions 

    Change-Id: I96a7d4454838cd30b5fe53196eae8709eedfdb44
    Roland Shoemaker committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    03be885 View commit details
    Browse the repository at this point in the history

  2. Allow user specifiable signature algorithm 

    Change-Id: I2feee394004948c6544a982aedfda5e815f92dc8
    Roland Shoemaker committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    9d51f04 View commit details
    Browse the repository at this point in the history

  3. Require crlSign key usage bit be set 

    Change-Id: I4babc5e0c817228e5c66711ce15ba12b7bebc113
    Roland Shoemaker committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    3aaef85 View commit details
    Browse the repository at this point in the history

  4. Update comment to mention keyUsage requirement 

    Change-Id: Id8496a6a6e61627c321a42c88535dcc31a4affc1
    Roland Shoemaker committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    f0cdbcd View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Update to finalized proposal 

    Change-Id: I3153f58a7ea47f1d63dc0e7a83340e0fe36126d6
    Roland Shoemaker committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    8eabd2f View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Address review comments 

    Change-Id: Id3aac8ac51844b473ce1914a25c6e4fdc444a02a
    Roland Shoemaker committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    46473e7 View commit details
    Browse the repository at this point in the history

  2. Add additional tests 

    Change-Id: I6050fdde7e61fd55bd3cb24aba9a4da233208071
    Roland Shoemaker committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    e5abe88 View commit details
    Browse the repository at this point in the history

  3. Add an Ed25519 test case 

    Change-Id: If40a06e7b7ff5481e16a32e51676bc00f3c6e8a2
    Roland Shoemaker committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    c83a601 View commit details
    Browse the repository at this point in the history