runtime: block console ctrlhandler when the signal is handled #41886

ncruces · 2020-10-09T16:40:22Z

I can confirm this change fixes my issue.
I can't confirm that this doesn't break any and everything else.
I see that this code has been tweaked repeatedly, so I would really welcome guidance into further testing.

Fixes #41884.

gopherbot · 2020-10-09T16:44:01Z

This PR (HEAD: 927af81) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-09T17:30:47Z

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-09T17:46:18Z

Message from Nuno Cruces:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-09T18:28:55Z

This PR (HEAD: 4fcde2f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-09T18:32:45Z

Message from Gobot Gobot:

Patch Set 2:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-10T00:03:45Z

Message from Nuno Cruces:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-10T00:51:44Z

This PR (HEAD: b6fa877) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-10T01:07:10Z

This PR (HEAD: 03abc2d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-10-10T01:10:57Z

Message from Nuno Cruces:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-10-15T03:46:58Z

Message from Go Bot:

Patch Set 2:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-12-04T11:45:04Z

Message from Nuno Cruces:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-03T14:39:04Z

This PR (HEAD: 54ffa75) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-03T14:54:26Z

Message from Nuno Cruces:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-03T15:03:43Z

This PR (HEAD: 4877073) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-04T08:34:31Z

Message from Alex Brainman:

Patch Set 6: Run-TryBot+1 Trust+1

(12 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-04T08:36:36Z

Message from Go Bot:

Patch Set 6:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=3c2926a7

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-04T08:50:25Z

Message from Go Bot:

Patch Set 6: TryBot-Result+1

SlowBots are happy.

SlowBot builds that ran:

windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-04T14:34:33Z

This PR (HEAD: 084270e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-12T09:26:24Z

Message from Go Bot:

Patch Set 9: TryBot-Result+1

SlowBots are happy.

SlowBot builds that ran:

windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-12T18:10:24Z

This PR (HEAD: 43b589f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-12T18:16:38Z

Message from Nuno Cruces:

Patch Set 10:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T18:05:29Z

Message from Jason A. Donenfeld:

Patch Set 10: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T18:05:30Z

Message from Go Bot:

Patch Set 10:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=b7e53656

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T18:14:55Z

Message from Go Bot:

Patch Set 10:

Build is still in progress...
This change failed on windows-amd64-longtest:
See https://storage.googleapis.com/go-build-log/b7e53656/windows-amd64-longtest_ecd2b0ed.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T18:18:45Z

Message from Go Bot:

Patch Set 10: TryBot-Result-1

1 of 22 SlowBots failed:
Failed on windows-amd64-longtest: https://storage.googleapis.com/go-build-log/b7e53656/windows-amd64-longtest_ecd2b0ed.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

SlowBot builds that ran:

windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T18:23:21Z

Message from Jason A. Donenfeld:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T19:13:56Z

This PR (HEAD: decd7b7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-23T19:17:47Z

Message from Nuno Cruces:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T22:39:19Z

Message from Jason A. Donenfeld:

Patch Set 11: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T22:39:20Z

Message from Go Bot:

Patch Set 11:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=399daaa4

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-23T22:53:14Z

Message from Go Bot:

Patch Set 11: TryBot-Result+1

SlowBots are happy.

SlowBot builds that ran:

windows-amd64-longtest

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-27T08:03:48Z

Message from Alex Brainman:

Patch Set 11:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-27T18:11:41Z

Message from Jason A. Donenfeld:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-27T18:13:41Z

Message from Jason A. Donenfeld:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-27T18:48:20Z

This PR (HEAD: 4ddb2d7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-27T19:02:42Z

This PR (HEAD: 92f02c9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/261057 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-01-27T19:06:42Z

Message from Jason A. Donenfeld:

Patch Set 12: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-27T19:06:42Z

Message from Go Bot:

Patch Set 12:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=f0d00f19

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-27T19:06:43Z

Message from Nuno Cruces:

Patch Set 12:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-27T19:06:44Z

Message from Jason A. Donenfeld:

Patch Set 13: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-01-27T19:10:42Z

Message from Go Bot:

Patch Set 13:

SlowBots beginning. Status page: https://farmer.golang.org/try?commit=4dee3cb3

Please don’t reply on this GitHub thread. Visit golang.org/cl/261057.
After addressing review feedback, remember to publish your drafts!

Fixes #41884 I can confirm this change fixes my issue. I can't confirm that this doesn't break any and everything else. I see that this code has been tweaked repeatedly, so I would really welcome guidance into further testing. Change-Id: I1986dd0c2f30cfe10257f0d8c658988d6986f7a6 GitHub-Last-Rev: 92f02c9 GitHub-Pull-Request: #41886 Reviewed-on: https://go-review.googlesource.com/c/go/+/261057 Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com> Trust: Jason A. Donenfeld <Jason@zx2c4.com> Trust: Alex Brainman <alex.brainman@gmail.com>

gopherbot · 2021-01-27T19:19:25Z

This PR is being closed because golang.org/cl/261057 has been merged.

Console CtrlHandler routine should block

927af81

Fixes #41884.

google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Oct 9, 2020

ncruces changed the title ~~runtime: block the console ctrlhandler when the signal is handled~~ runtime: block console ctrlhandler when the signal is handled Oct 9, 2020

Merge remote-tracking branch 'upstream/master' into 41884-fix

4fcde2f

Add test case.

b6fa877

Block indefinitely only for irrecoverable conditions.

03abc2d

ncruces mentioned this pull request Oct 11, 2020

runtime: handling of CTRL_CLOSE_EVENT seems broken #41884

Closed

ncruces added 2 commits January 3, 2021 14:28

Merge remote-tracking branch 'upstream/master' into 41884-fix

07f61d0

Ensure test exits cleanly before being killed.

54ffa75

Fix test.

4877073

ncruces added 2 commits January 4, 2021 13:20

Wait for child.

b52e899

Review changes.

084270e

Review comments.

43b589f

Merge remote-tracking branch 'upstream/master' into 41884-fix

decd7b7

Review comments.

4ddb2d7

Merge remote-tracking branch 'upstream/master' into 41884-fix

92f02c9

gopherbot closed this Jan 27, 2021

runtime: block console ctrlhandler when the signal is handled #41886

runtime: block console ctrlhandler when the signal is handled #41886

Conversation

ncruces commented Oct 9, 2020

gopherbot commented Oct 9, 2020

gopherbot commented Oct 9, 2020

gopherbot commented Oct 9, 2020

gopherbot commented Oct 9, 2020

gopherbot commented Oct 9, 2020

gopherbot commented Oct 10, 2020

gopherbot commented Oct 10, 2020

gopherbot commented Oct 10, 2020

gopherbot commented Oct 10, 2020

gopherbot commented Oct 15, 2020

gopherbot commented Dec 4, 2020

gopherbot commented Jan 3, 2021

gopherbot commented Jan 3, 2021

gopherbot commented Jan 3, 2021

gopherbot commented Jan 4, 2021

gopherbot commented Jan 4, 2021

gopherbot commented Jan 4, 2021

gopherbot commented Jan 4, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 12, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 23, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021

gopherbot commented Jan 27, 2021