-
Notifications
You must be signed in to change notification settings - Fork 18k
encoding/csv: allow for interpretation of empty lines #45228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Empty lines are ignored by default, this change introduces a switch that changes this behaviour - empty line is then interpreted as a single empty field.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 3c15a37) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/363001 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/363001. |
Message from Ian Lance Taylor: Patch Set 1: Code-Review-2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/363001. |
Message from Daniel Martí: Patch Set 1: Code-Review-2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/363001. |
Any updates on this? PR is fairly straight-forward but has been open for almost a year. |
There is a -2 during review, please visit https://go-review.googlesource.com/c/go/+/363001#message-4d1a47dfc5dd28a78ccbf7bffa8843f975b1e011 for more information |
That was 2 months ago though. If I understand correctly, the PR will not be accepted until there is a proposal put through first by the person who submitted the PR? |
The original issue did not include a proposal, because at the very beginning we didn't have a potential solution at hand. During the discussion I came up with a potential solution, which could be made into a proposal - #39119 (comment) - I recently thought about proposing this in a structured way, if there's interest. |
Message from Russ Cox: Patch Set 1: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/363001. |
Thanks to @kokes for the initial effort on this PR
Empty lines are ignored by default, this change introduces a switch that
changes this behaviour - empty line is then interpreted as a single empty
field. This is especially important when dealing with single-column CSVs,
where an empty line is actually data (an empty field).
Fixes #39119 and supersedes stalled PR #39556