Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/go1.17: document flag changes for Go 1.17 #46150

Closed
wants to merge 2 commits into from
Closed

doc/go1.17: document flag changes for Go 1.17 #46150

wants to merge 2 commits into from

Conversation

KimMachineGun
Copy link
Contributor

For #44513
Fixes #46010

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 13, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 5c5ffb9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/319273 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/319273.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/319273.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Heschi Kreinick:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/319273.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: d5bd53b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/319273 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Geon Kim:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/319273.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jun 2, 2021
@KimMachineGun @heschi
doc/go1.17: document flag changes for Go 1.17
d743e67 
For #44513
Fixes #46010

Change-Id: I1fe638e5db0b4f3b64dbfbd948154a7c7a80afc9
GitHub-Last-Rev: d5bd53b
GitHub-Pull-Request: #46150
Reviewed-on: https://go-review.googlesource.com/c/go/+/319273
Reviewed-by: Heschi Kreinick <heschi@google.com>
Trust: Robert Findley <rfindley@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/319273 has been merged.

@gopherbot gopherbot closed this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc/go1.17: document flag changes for Go 1.17
2 participants
@KimMachineGun @gopherbot