Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: add crypto/tls.VersionName function #46309

Closed

Conversation

skgsergio
Copy link

This function returns an string representation (TLSv1.0, TLSv1.1, ...)
given a TLS version number.

Fixes #46308

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 21, 2021
This function returns an string representation (`TLSv1.0`, `TLSv1.1`, ...)
given a TLS version number.

Fixes golang#46308
@skgsergio skgsergio force-pushed the crypto/tls/add-VersionName-func branch from 1b9e25a to d278e20 Compare May 21, 2021 15:15
@gopherbot
Copy link
Contributor

This PR (HEAD: d278e20) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/321733 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/321733.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Code-Review-2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/321733.
After addressing review feedback, remember to publish your drafts!

@s-silvius
Copy link

+1

@shujun10086
Copy link

+1 it would be a very useful function

@skgsergio
Copy link
Author

skgsergio commented Oct 18, 2024

Closing this PR as it was done later in b267db0 (probably because I missed Gerrit comments)

@skgsergio skgsergio closed this Oct 18, 2024
@skgsergio skgsergio deleted the crypto/tls/add-VersionName-func branch October 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crypto/tls: add VersionName function to return a string version of the TLS Version
4 participants