Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/test: clarify -count default #48388

Closed
wants to merge 1 commit into from

Conversation

ScottSuarez
Copy link

@ScottSuarez ScottSuarez commented Sep 14, 2021

Count default is only 1 when the test is not cached.
If the test is cached it will not rerun the test.

This documentation causes confusion because the only way to run tests without cache is to use -count=1. According to the documentation as is -count=1 should have no effect. Changing this CLI documentation to clarify the behavior.

ref: #39056
resolves: #39056

Count default is only 1 when the test is not cached. 

If the test is cached it will not rerun the test. [This causes confusion because the only way to run tests without cache is to use -count=1.](golang#39056) According to the documentation as is `-count=1` should have no effect. Changing this CLI documentation to clarify the behavior.
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Sep 14, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 3be413f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/349933 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/349933.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 2: Code-Review-1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/349933.
After addressing review feedback, remember to publish your drafts!

@ScottSuarez
Copy link
Author

closing this after comment inline clarified with explanation for current description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: cmd/go: add flag go test -no-cache
2 participants