cmd/go: cache coverage profile with tests #50483

jproberts · 2022-01-06T23:10:15Z

This CL stores coverage profile data in the GOCACHE under the
'coverprofile' subkey alongside tests. This makes tests which use
coverage profiles cacheable. The values of the -coverprofile and
-outputdir flags are not included in the cache key to allow cached
profile data to be written to any output file.

Fixes #23565

gopherbot · 2022-01-06T23:15:31Z

This PR (HEAD: 9ada311) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/376134 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-01-06T23:18:54Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

vearutop · 2022-01-07T09:27:04Z

I tried this PR with gotip download 376134 and it worked well for me, thank you! Hopefully coverage cache will make it in 1.19.

jproberts · 2022-01-07T13:47:18Z

Thanks for the feedback @vearutop ! I agree that this change is unlikely to make it into 1.18. It's too risky this late in the release cycle. I decided to open the PR anyway in case the community wanted to test and review before the Go team does. I appreciate you taking the time to try it out and I'm happy to hear it works 😃

gopherbot · 2022-04-08T00:06:27Z

Message from James Roberts:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-16T12:33:18Z

Message from Than McIntosh:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-21T01:05:10Z

This PR (HEAD: de26ed4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/376134 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-06-21T01:52:41Z

Message from James Roberts:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-06-22T20:52:46Z

Message from Bryan Mills:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-08-10T01:24:57Z

This PR (HEAD: 3e83a00) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/376134 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-08-10T01:54:20Z

This PR (HEAD: 6c1281a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/376134 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-08-10T02:07:28Z

Message from James Roberts:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-10-05T21:16:55Z

Message from Bryan Mills:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-10-17T00:34:50Z

This PR (HEAD: 0990fbf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/376134 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-10-17T00:43:07Z

Message from James Roberts:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-10-17T14:11:35Z

Message from Than McIntosh:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2022-10-17T14:52:49Z

This PR (HEAD: af9a74c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/376134 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-10-17T14:57:48Z

Message from James Roberts:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/376134.
After addressing review feedback, remember to publish your drafts!

src/cmd/go/internal/test/test.go

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Fixes golang#23565

gopherbot · 2023-07-25T21:15:43Z

This PR (HEAD: ace4a17) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/376134.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs golang#50483 and golang#65657 that was created/closed by @jproberts and @macnibblet that I plan to maintain. I made improvements to the PR based on feedback from @bcmills. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565 Signed-off-by: Ryan Currah <ryan@currah.ca>

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs golang#50483 and golang#65657 that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. I made improvements to the PR based on feedback from @bcmills here https://go-review.googlesource.com/c/go/+/563138. y From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565 Signed-off-by: Ryan Currah <ryan@currah.ca>

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs golang#50483 and golang#65657 that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. I made improvements to the PR based on feedback from @bcmills here https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565 Signed-off-by: Ryan Currah <ryan@currah.ca>

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs golang#50483 and golang#65657 that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. I made improvements to the PR based on feedback from @bcmills here https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565 Signed-off-by: Ryan Currah <ryan@currah.ca>

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - golang#50483 - golang#65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes golang#23565

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - #50483 - #65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes #23565 Change-Id: I59a20af5ea156f990a17544cf06dc667ae7f8aa3 GitHub-Last-Rev: a5a1d1b GitHub-Pull-Request: #69339 Reviewed-on: https://go-review.googlesource.com/c/go/+/610564 Reviewed-by: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@golang.org> Reviewed-by: Junyang Shao <shaojunyang@google.com>

jproberts force-pushed the cache-coverprofile-with-tests branch from 74b0e24 to de26ed4 Compare June 21, 2022 01:01

jproberts force-pushed the cache-coverprofile-with-tests branch 2 times, most recently from 4c5fb3c to 3e83a00 Compare August 10, 2022 00:20

jproberts force-pushed the cache-coverprofile-with-tests branch from 6c1281a to 0990fbf Compare October 17, 2022 00:33

tydavis reviewed Nov 29, 2022

View reviewed changes

src/cmd/go/internal/test/test.go Outdated Show resolved Hide resolved

jproberts added 7 commits July 25, 2023 09:14

Add debug log on error closing temp coverprofile

e569174

Rename var for clarity

a8e42e1

Clarify comment

4259842

Add TODOs to fail test if merge fails

7ebc838

Simplify saveCoverProfile using bcmills' comment

a9b40ae

Attempt to rollback failed merges

1ca3e0e

jproberts added 2 commits July 25, 2023 09:15

Fix error string

e544e95

resolve conflicts

ace4a17

jproberts force-pushed the cache-coverprofile-with-tests branch from af9a74c to ace4a17 Compare July 25, 2023 21:11

jproberts closed this Jul 25, 2023

awartoft mentioned this pull request Feb 11, 2024

cmd/go: cache coverage profile with tests #65657

Open

ryancurrah mentioned this pull request Sep 7, 2024

cmd/go: cache coverage profile with tests #69339

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/go: cache coverage profile with tests #50483

cmd/go: cache coverage profile with tests #50483

jproberts commented Jan 6, 2022

gopherbot commented Jan 6, 2022

gopherbot commented Jan 6, 2022

vearutop commented Jan 7, 2022

jproberts commented Jan 7, 2022

gopherbot commented Apr 8, 2022

gopherbot commented Jun 16, 2022

gopherbot commented Jun 21, 2022

gopherbot commented Jun 21, 2022

gopherbot commented Jun 22, 2022

gopherbot commented Aug 10, 2022

gopherbot commented Aug 10, 2022

gopherbot commented Aug 10, 2022

gopherbot commented Oct 5, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Jul 25, 2023

cmd/go: cache coverage profile with tests #50483

cmd/go: cache coverage profile with tests #50483

Conversation

jproberts commented Jan 6, 2022

gopherbot commented Jan 6, 2022

gopherbot commented Jan 6, 2022

vearutop commented Jan 7, 2022

jproberts commented Jan 7, 2022

gopherbot commented Apr 8, 2022

gopherbot commented Jun 16, 2022

gopherbot commented Jun 21, 2022

gopherbot commented Jun 21, 2022

gopherbot commented Jun 22, 2022

gopherbot commented Aug 10, 2022

gopherbot commented Aug 10, 2022

gopherbot commented Aug 10, 2022

gopherbot commented Oct 5, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Oct 17, 2022

gopherbot commented Jul 25, 2023