Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io/ioutil: add deprecation markers to ioutil #51961

Closed
wants to merge 2 commits into from
Closed

io/ioutil: add deprecation markers to ioutil #51961

wants to merge 2 commits into from

Conversation

jeffwidman
Copy link
Contributor

@jeffwidman jeffwidman commented Mar 26, 2022 •
edited
Loading

All the code in ioutil just forwards functionality to code
in either the io or os packages, per issue 42026.

This change adds the "Deprecated" marker to all the
functions in this package.

For #42026

Fixes #51927

dlsniper and others added 2 commits March 25, 2022 23:59
@dlsniper @jeffwidman
io/ioutil: flag package and functions with the Deprecated marker
aae1fbd 
All implementations are now part of `io` or `os` packages, per #42026.
Flag all implementations in `ioutil`, and the package itself, with
the Deprecated marker so that tooling can pick it up and interpret
it accordingly.

Updates #42026
@jeffwidman
io/ioutil: Deprecate TempFile and TempDir
3c3603f 
These were deprecated in `go` `1.17`, so marked them as officially
`Deprecated: `.

Fix #51927
@jeffwidman
Copy link
Contributor Author

@dlsniper FYI I cherry-picked your original take on this from #43799 to ensure you get credit and then added a commit for the deprecations in ioutil/tempfile.go since that file changed a little since your original PR.

@gopherbot
Copy link
Contributor

This PR (HEAD: 3c3603f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/395918 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/395918.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 2: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/395918.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/395918.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/395918.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Emmanuel Odeke:

Patch Set 3: Run-TryBot+1 Code-Review+2 Trust+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/395918.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/395918.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/395918.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/395918 has been merged.

@gopherbot gopherbot closed this Mar 28, 2022
gopherbot pushed a commit that referenced this pull request Mar 28, 2022
@jeffwidman @ianlancetaylor
io/ioutil: add deprecation markers to ioutil
a208aa7 
All the code in ioutil just forwards functionality to code
in either the io or os packages, per issue 42026.

This change adds the "Deprecated" marker to all the
functions in this package.

For #42026

Fixes #51927

Change-Id: Ia807bc5c0edb06cc80ec7e35917dcfe2ad50f0ea
GitHub-Last-Rev: 3c3603f
GitHub-Pull-Request: #51961
Reviewed-on: https://go-review.googlesource.com/c/go/+/395918
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@jeffwidman jeffwidman deleted the add-deprecation-markers-to-ioutil branch April 28, 2022 21:47
This was referenced Jul 23, 2022
Merged
Closed
kiashok pushed a commit to kiashok/containerd-containerd that referenced this pull request Oct 23, 2024
@jeffwidman
Drop deprecated ioutil
3a42c23 
`ioutil` has been deprecated by golang. All the code in `ioutil` just
forwards functionality to code in either the `io` or `os` packages.

See golang/go#51961 for more info.

Signed-off-by: Jeff Widman <jeff@jeffwidman.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: io/ioutil: Annotate functions with "Deprecated: "
3 participants
@jeffwidman @gopherbot @dlsniper