-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flag: support func flags without arguments #53748
Conversation
Current implementation forces a func flag to have a value When displaying the usage is possible to see a "value" required for the flag and when you execute it without flag you receive the error flag needs an argument Converted funcValue to a struct and create 2 additional functions to avoid breaking changes Fixes golang#53747
This PR (HEAD: 635f52e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/416514 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/416514. |
Message from Ian Lance Taylor: Patch Set 1: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/416514. |
This PR (HEAD: 2a1b932) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/416514 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: ced6c00) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/416514 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 3: Hold+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/416514. |
Message from Ian Lance Taylor: Patch Set 3: -Hold Please don’t reply on this GitHub thread. Visit golang.org/cl/416514. |
Message from Rob Pike: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/416514. |
Message from Carl Johnson: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/416514. |
Message from Ian Lance Taylor: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/416514. |
@carlmjohnson, sorry for not replying I've been busy with other stuff and I kind of forgot about this... thanks for fixing it |
Current implementation forces a func flag to have a value
When displaying the usage is possible to see a "value" required for the flag and when you execute it without flag you receive the error flag needs an argument
Converted funcValue to a struct and create 2 additional functions to avoid breaking changes
#53747