Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flag: support func flags without arguments #53748

Closed
wants to merge 3 commits into from

Conversation

fnxpt
Copy link

@fnxpt fnxpt commented Jul 8, 2022

Current implementation forces a func flag to have a value
When displaying the usage is possible to see a "value" required for the flag and when you execute it without flag you receive the error flag needs an argument

Converted funcValue to a struct and create 2 additional functions to avoid breaking changes

#53747

    Current implementation forces a func flag to have a value
    When displaying the usage is possible to see a "value" required for the flag and when you execute it without flag you receive the error flag needs an argument

    Converted funcValue to a struct and create 2 additional functions to avoid breaking changes

    Fixes golang#53747
@gopherbot
Copy link
Contributor

This PR (HEAD: 635f52e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/416514 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/416514.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Hold+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/416514.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 2a1b932) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/416514 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: ced6c00) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/416514 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: Hold+1

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/416514.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3: -Hold


Please don’t reply on this GitHub thread. Visit golang.org/cl/416514.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rob Pike:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/416514.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carl Johnson:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/416514.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/416514.
After addressing review feedback, remember to publish your drafts!

@fnxpt
Copy link
Author

fnxpt commented Mar 29, 2023

@carlmjohnson, sorry for not replying I've been busy with other stuff and I kind of forgot about this... thanks for fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants