-
Notifications
You must be signed in to change notification settings - Fork 18k
archive/zip: add AddFS method to zip Writer #61602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The method AddFS can be used to add the contents of a fs.FS filesystem to a zip archive. This method walks the directory tree starting at the root of the filesystem and adds each file to the archive. Fixes: golang#54898
This PR (HEAD: 8c5ab09) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/513438. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Ingo Oeser: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Mauri de Souza Meneguzzo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
This PR (HEAD: 3b4f4a5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/513438. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
This PR (HEAD: f4ad530) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/513438. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Ian Lance Taylor: Patch Set 3: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Mauri de Souza Meneguzzo: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
This PR (HEAD: 0e900d2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/513438. Important tips:
|
Message from Gopher Robot: Patch Set 4: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Ian Lance Taylor: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Mauri de Souza Meneguzzo: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Ian Lance Taylor: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 5: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
This PR (HEAD: ceb8a3b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/513438. Important tips:
|
Message from Mauri de Souza Meneguzzo: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Ian Lance Taylor: Patch Set 6: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Mauri de Souza Meneguzzo: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 6: TryBot-Result-1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
This PR (HEAD: 1e17f2e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/513438. Important tips:
|
Message from Ian Lance Taylor: Patch Set 7: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Gopher Robot: Patch Set 7: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
Message from Ian Lance Taylor: Patch Set 7: Auto-Submit+1 Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/513438. |
The method AddFS can be used to add the contents of a fs.FS filesystem to a zip archive. This method walks the directory tree starting at the root of the filesystem and adds each file to the archive. Fixes #54898 Change-Id: I80511cbd91a1d7e09ee52d2d1b09fb5eed25f45f GitHub-Last-Rev: 1e17f2e GitHub-Pull-Request: #61602 Reviewed-on: https://go-review.googlesource.com/c/go/+/513438 Reviewed-by: David Chase <drchase@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@google.com>
This PR is being closed because golang.org/cl/513438 has been merged. |
The method AddFS can be used to add the contents of a fs.FS filesystem
to a zip archive.
This method walks the directory tree starting at the root of the filesystem
and adds each file to the archive.
Fixes #54898