crypto/x509: add new OID type and use it in Certificate #62096

mateusz834 · 2023-08-17T15:18:34Z

Fixes #60665

gopherbot · 2023-08-17T15:24:32Z

This PR (HEAD: ef4c254) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-17T15:30:27Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T15:30:36Z

This PR (HEAD: c531c36) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-17T15:36:30Z

Message from Mateusz Poliwczak:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T15:36:31Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T15:42:12Z

Message from Mateusz Poliwczak:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T15:42:13Z

Message from Gopher Robot:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-17T15:59:25Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-19T09:56:42Z

This PR (HEAD: 818cb93) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-19T10:02:04Z

Message from Mateusz Poliwczak:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-19T10:07:17Z

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-19T10:17:54Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T05:55:10Z

This PR (HEAD: f8bd8a7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-31T06:01:21Z

This PR (HEAD: fbe8b17) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-31T06:07:38Z

Message from Mateusz Poliwczak:

Patch Set 5: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T06:13:38Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T06:25:51Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T06:38:33Z

This PR (HEAD: 8d55b5e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-31T06:44:41Z

Message from Mateusz Poliwczak:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T06:44:49Z

This PR (HEAD: 59af247) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-08-31T06:51:04Z

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T06:51:05Z

Message from Mateusz Poliwczak:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T06:57:18Z

Message from Gopher Robot:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T07:03:37Z

Message from Gopher Robot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-08-31T07:09:57Z

Message from Gopher Robot:

Patch Set 7: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-21T11:58:26Z

Message from Gopher Robot:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-09-21T12:05:49Z

Message from Gopher Robot:

Patch Set 11: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-29T19:27:26Z

Message from Mateusz Poliwczak:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-30T18:43:55Z

Message from Roland Shoemaker:

Patch Set 11: Code-Review+2

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-30T19:17:13Z

This PR (HEAD: bd3b3cd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-30T19:24:06Z

Message from Mateusz Poliwczak:

Patch Set 12: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-30T19:30:34Z

Message from Gopher Robot:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-30T19:37:17Z

Message from Gopher Robot:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-30T19:37:18Z

Message from Gopher Robot:

Patch Set 12: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-30T19:37:19Z

Message from Mateusz Poliwczak:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

Change-Id: I7995062717bb6308dd8a735e8a235a19b41b1b89

Change-Id: Icc7b68161dca294e6524f6efb1c690b80b48f96e

Change-Id: Idb0b519fd208357e427c9ea37ec425d066ffca63

Change-Id: Id455c927d55dfe40cafc9d051213f9246d290ccb

Change-Id: I77015c8c44521afd52c9bec86c158e4344bd8b48

Change-Id: I99701776951a81edf1ade8e55b0da1d08a51d865

Change-Id: I54d753bd280219f9392cb9061088132e526d1800

gopherbot · 2023-10-31T17:26:48Z

This PR (HEAD: 693c741) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/520535.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-31T17:33:39Z

Message from Mateusz Poliwczak:

Patch Set 13: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-31T17:40:16Z

Message from Gopher Robot:

Patch Set 13:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-31T17:47:04Z

Message from Gopher Robot:

Patch Set 13: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-31T17:47:05Z

Message from Roland Shoemaker:

Patch Set 13: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-31T17:53:54Z

Message from Roland Shoemaker:

Patch Set 13: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/520535.
After addressing review feedback, remember to publish your drafts!

Fixes #60665 Change-Id: I814b7d4b26b964f74443584fb2048b3e27e3b675 GitHub-Last-Rev: 693c741 GitHub-Pull-Request: #62096 Reviewed-on: https://go-review.googlesource.com/c/go/+/520535 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Mateusz Poliwczak <mpoliwczak34@gmail.com> Auto-Submit: Roland Shoemaker <roland@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>

gopherbot · 2023-10-31T19:31:27Z

This PR is being closed because golang.org/cl/520535 has been merged.

Fixes #60665 Change-Id: I814b7d4b26b964f74443584fb2048b3e27e3b675 GitHub-Last-Rev: 693c741c76e6369e36aa2a599ee6242d632573c7 GitHub-Pull-Request: golang/go#62096 Reviewed-on: https://go-review.googlesource.com/c/go/+/520535 TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Mateusz Poliwczak <mpoliwczak34@gmail.com> Auto-Submit: Roland Shoemaker <roland@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>

mateusz834 changed the title ~~crypto/x509 add new OID type and use it in Certificate~~ crypto/x509: add new OID type and use it in Certificate Aug 17, 2023

mateusz834 force-pushed the x509-OID-type branch from e6a4f4d to 818cb93 Compare August 19, 2023 09:55

mateusz834 force-pushed the x509-OID-type branch from 818cb93 to f8bd8a7 Compare August 31, 2023 05:51

mateusz834 force-pushed the x509-OID-type branch from 8d55b5e to 59af247 Compare August 31, 2023 06:43

mateusz834 force-pushed the x509-OID-type branch from 59af247 to 89f65eb Compare September 1, 2023 15:30

mateusz834 force-pushed the x509-OID-type branch from 2c9ea56 to bd3b3cd Compare October 30, 2023 19:14

mateusz834 added 8 commits October 31, 2023 18:24

crypto/x509 add new OID type and use it in Certificate

aaaf27a

add copyright comment

156f735

Change-Id: I7995062717bb6308dd8a735e8a235a19b41b1b89

add test, support creating certificates with new OID type

951159a

Change-Id: Icc7b68161dca294e6524f6efb1c690b80b48f96e

update Certificate fields doc comments

06c7250

Change-Id: Idb0b519fd208357e427c9ea37ec425d066ffca63

simplify

1b59fff

Change-Id: Id455c927d55dfe40cafc9d051213f9246d290ccb

simplify base128IntLength

ba43130

Change-Id: I77015c8c44521afd52c9bec86c158e4344bd8b48

use type inference better

9e9479a

Change-Id: I99701776951a81edf1ade8e55b0da1d08a51d865

update

693c741

Change-Id: I54d753bd280219f9392cb9061088132e526d1800

mateusz834 force-pushed the x509-OID-type branch from bd3b3cd to 693c741 Compare October 31, 2023 17:24

gopherbot closed this Oct 31, 2023

crypto/x509: add new OID type and use it in Certificate #62096

crypto/x509: add new OID type and use it in Certificate #62096

Conversation

mateusz834 commented Aug 17, 2023

gopherbot commented Aug 17, 2023

gopherbot commented Aug 17, 2023

gopherbot commented Aug 17, 2023

gopherbot commented Aug 17, 2023

gopherbot commented Aug 17, 2023

gopherbot commented Aug 17, 2023

gopherbot commented Aug 17, 2023

gopherbot commented Aug 17, 2023

gopherbot commented Aug 19, 2023

gopherbot commented Aug 19, 2023

gopherbot commented Aug 19, 2023

gopherbot commented Aug 19, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Aug 31, 2023

gopherbot commented Sep 21, 2023

gopherbot commented Sep 21, 2023

gopherbot commented Oct 29, 2023

gopherbot commented Oct 30, 2023

gopherbot commented Oct 30, 2023

gopherbot commented Oct 30, 2023

gopherbot commented Oct 30, 2023

gopherbot commented Oct 30, 2023

gopherbot commented Oct 30, 2023

gopherbot commented Oct 30, 2023

gopherbot commented Oct 31, 2023

gopherbot commented Oct 31, 2023

gopherbot commented Oct 31, 2023

gopherbot commented Oct 31, 2023

gopherbot commented Oct 31, 2023

gopherbot commented Oct 31, 2023

gopherbot commented Oct 31, 2023