runtime: let the fault thread to crash the process #63666

zzkcode · 2023-10-22T08:40:49Z

Let the fault thread to crash the program to make sure while gdb coredump file could see the correct backtrace in the number one thread in gdb.

Fixes #63277.

gopherbot · 2023-10-22T08:45:33Z

This PR (HEAD: f231010) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/536895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-10-22T08:52:33Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-22T08:52:34Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-22T10:10:18Z

Message from zk Z:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-31T02:19:37Z

Message from zk Z:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-10-31T16:18:23Z

Message from Cherry Mui:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-01T01:01:08Z

Message from zk Z:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-06T14:11:42Z

Message from zk Z:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-07T21:26:10Z

Message from Cherry Mui:

Patch Set 3: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-07T21:33:20Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-07T21:18:03Z","revision":"32f455b1e76bbcd94104e7a70d0693ab90de6244"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-07T21:33:21Z

Message from Cherry Mui:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-07T21:33:21Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 536895)
tools on master (commit 51df92b)

error: failed to run "test golang.org/x/tools module": exit status 1

"test golang.org/x/tools module" (combined output)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-07T21:33:22Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T13:39:54Z

This PR (HEAD: 7255f1f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/536895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-09T13:53:43Z

Message from zk Z:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-09T13:53:44Z

Message from zk Z:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-13T13:08:25Z

Message from zk Z:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-15T13:46:34Z

Message from zk Z:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-18T04:54:32Z

Message from Cherry Mui:

Patch Set 4: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T18:40:33Z

Message from Michael Pratt:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T14:53:14Z

This PR (HEAD: 08249f1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/536895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-21T15:17:32Z

Message from zk Z:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-21T15:33:26Z

This PR (HEAD: 82a0799) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/536895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-21T15:57:05Z

Message from zk Z:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-28T16:06:10Z

Message from zk Z:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-28T21:01:39Z

Message from Michael Pratt:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T16:08:12Z

This PR (HEAD: 8aa7446) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/536895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-29T16:22:24Z

Message from zk Z:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T17:57:42Z

Message from Michael Pratt:

Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T17:57:43Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-29T17:50:16Z","revision":"947daf3cde93cfce8ed2ca46b1df3d2a1b74aaaa"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:11:21Z

Message from Michael Pratt:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:11:22Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results):

FAILURE

go on master (change 536895)

error: shard 2: failed to run "go tool dist test -json": exit status 1

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:11:23Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T19:31:29Z

Message from Michael Pratt:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

…sh concurrently & fix typo

gopherbot · 2023-11-30T11:39:33Z

This PR (HEAD: f4615c2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/536895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-30T12:37:33Z

Message from zk Z:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:44:33Z

Message from Cherry Mui:

Patch Set 8: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:51:59Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-30T14:34:27Z","revision":"6f513e0726d01e6aaeb0607e9db64f2a39ea444b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:59:43Z

Message from Cherry Mui:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:59:44Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:59:45Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-01T15:27:12Z

Message from zk Z:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-01T15:55:14Z

Message from zk Z:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/536895.
After addressing review feedback, remember to publish your drafts!

Let the fault thread to crash the program to make sure while gdb coredump file could see the correct backtrace in the number one thread in gdb. Fixes #63277. Change-Id: Ie4473f76f0feba596091433918bcd35a4ff7e11b GitHub-Last-Rev: f4615c2 GitHub-Pull-Request: #63666 Reviewed-on: https://go-review.googlesource.com/c/go/+/536895 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2023-12-02T03:23:15Z

This PR is being closed because golang.org/cl/536895 has been merged.

zzkcode force-pushed the runtime_fix-incorrect-crash-thread branch 2 times, most recently from aca6442 to 7255f1f Compare November 9, 2023 13:37

zzkcode force-pushed the runtime_fix-incorrect-crash-thread branch from 7255f1f to 08249f1 Compare November 21, 2023 14:51

zzkcode force-pushed the runtime_fix-incorrect-crash-thread branch from 08249f1 to 82a0799 Compare November 21, 2023 15:27

zzkcode force-pushed the runtime_fix-incorrect-crash-thread branch from 82a0799 to 8aa7446 Compare November 29, 2023 16:05

zzkcode added 6 commits November 30, 2023 19:35

runtime: let the fault thread to crash the process

e5916e6

runtime: update comments and make crashing atomic

40765fe

runtime: add test for fault thread crash process

398a0fe

runtime: use CompareAndSwap to avoid racy issue while two threads cra…

9e17136

…sh concurrently & fix typo

runtime: extract canGenerateCore

2a9f9e2

runtime: remove CGO CFLAGS -Wall

f4615c2

zzkcode force-pushed the runtime_fix-incorrect-crash-thread branch from 8aa7446 to f4615c2 Compare November 30, 2023 11:38

zzkcode mentioned this pull request Nov 30, 2023

runtime: panic not generating a correct backtrace stack while crashing in cgo #63277

Closed

gopherbot closed this Dec 2, 2023

runtime: let the fault thread to crash the process #63666

runtime: let the fault thread to crash the process #63666

Conversation

zzkcode commented Oct 22, 2023 • edited Loading

gopherbot commented Oct 22, 2023

gopherbot commented Oct 22, 2023

gopherbot commented Oct 22, 2023

gopherbot commented Oct 22, 2023

gopherbot commented Oct 31, 2023

gopherbot commented Oct 31, 2023

gopherbot commented Nov 1, 2023

gopherbot commented Nov 6, 2023

gopherbot commented Nov 7, 2023

gopherbot commented Nov 7, 2023

gopherbot commented Nov 7, 2023

gopherbot commented Nov 7, 2023

gopherbot commented Nov 7, 2023

gopherbot commented Nov 9, 2023

gopherbot commented Nov 9, 2023

gopherbot commented Nov 9, 2023

gopherbot commented Nov 13, 2023

gopherbot commented Nov 15, 2023

gopherbot commented Nov 18, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 21, 2023

gopherbot commented Nov 28, 2023

gopherbot commented Nov 28, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 2, 2023

zzkcode commented Oct 22, 2023 •

edited

Loading