-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go/internal/envcmd: show GODEBUG in 'go env' output #65888
Conversation
Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com>
This PR (HEAD: a395b02) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/566097. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Hope we're not stepping on any toes. There was another CL addressing this issue, but its status is listed as "abandoned" in Gerrit. We considered making |
Message from Arati: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Arati: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Jes Cok: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-28T13:37:09Z","revision":"180d7472caf46a66d67c8b169023a89835ec5e94"} Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Jes Cok: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results): FAILURE
Error: Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Bryan Mills: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Bryan Mills: Patch Set 3: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-28T20:12:44Z","revision":"aa44a2c53861bd2983df7b8d52e4ce88d60eafaf"} Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Bryan Mills: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Message from Bryan Mills: Patch Set 3: Auto-Submit+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/566097. |
Fixes #65777 Change-Id: I62067d8212bfd9f9475ecad036a1218ffc5c2130 GitHub-Last-Rev: a395b02 GitHub-Pull-Request: #65888 Reviewed-on: https://go-review.googlesource.com/c/go/+/566097 Reviewed-by: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org>
This PR is being closed because golang.org/cl/566097 has been merged. |
Fixes #65777