Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo: enable #cgo noescape/nocallback #66879

Closed
wants to merge 8 commits into from
Closed

cmd/cgo: enable #cgo noescape/nocallback #66879

wants to merge 8 commits into from

Commits on Jul 5, 2024

  1. Revert "cmd/cgo: disable #cgo noescape/nocallback until Go 1.23" 

    This reverts commit 607e020.

Reason for revert: Go1.22 is released.

It's aggressive to introdcue #cgo noescape/nocallback in Go1.22, as in golang#63739
And it won't be a problem again while upgrading from Go1.22 to Go1.23.

fix golang#56378

Signed-off-by: doujiang24 <doujiang24@gmail.com>
    @doujiang24
    doujiang24 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    3f400c4 View commit details
    Browse the repository at this point in the history

  2. fix escape 

    Signed-off-by: doujiang24 <doujiang24@gmail.com>
    @doujiang24
    doujiang24 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    672e5be View commit details
    Browse the repository at this point in the history

  3. add test 

    Signed-off-by: doujiang24 <doujiang24@gmail.com>
    @doujiang24
    doujiang24 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    2f4b5d8 View commit details
    Browse the repository at this point in the history

  4. use cgoKeepAlive 

    Signed-off-by: doujiang24 <doujiang24@gmail.com>
    @doujiang24
    doujiang24 committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    34903bf View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. fix windows test 

    Signed-off-by: doujiang24 <doujiang24@gmail.com>
    @doujiang24
    doujiang24 committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    4098234 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. still escaple pointer when only noescape exists. 

    Signed-off-by: doujiang24 <doujiang24@gmail.com>
    @doujiang24
    doujiang24 committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8dc86e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. address comments. 

    Signed-off-by: doujiang24 <doujiang24@gmail.com>
    @doujiang24
    doujiang24 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    766ea1b View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. address comments. 

    Signed-off-by: doujiang24 <doujiang24@gmail.com>
    @doujiang24
    doujiang24 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    42fcc50 View commit details
    Browse the repository at this point in the history