cmd/go: fail go clean command when failed to find go cache directory #70392

mneverov · 2024-11-16T13:40:48Z

Currently, if computing of the go cache directory fails it does not expose the error. Commands like go clean, exec, modindex that use go cache directory continue execution producing incorrect or no result. This patch adds an error to the return values such that it can be validated on call sites. It also introduces such validation in go clean -cache command to fail execution in case when error occurred.

Fixes #69997

gopherbot · 2024-11-16T13:45:30Z

This PR (HEAD: 69a6fb5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-16T13:52:54Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-16T15:21:58Z

Message from Max Neverov:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-16T15:21:58Z

Message from Max Neverov:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T09:28:27Z

Message from Jorropo:

Patch Set 1: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T09:28:27Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-17T09:14:33Z","revision":"5ea8c7f7fd992cdeb1e882e9802691d9359a7a1d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T09:28:27Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Copied votes on follow-up patch sets have been updated:

LUCI-TryBot-Result-1 has been copied to patch set 2 (copy condition: "changekind:NO_CODE_CHANGE").

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T09:35:33Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-17T09:21:18Z","revision":"2aa258edd49c59e5eb3606daf68e8fe71e715ada"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T10:30:54Z

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T10:30:54Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T10:30:55Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T15:56:25Z

Message from Max Neverov:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-17T18:10:24Z

Message from Jorropo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T06:58:02Z

Message from Max Neverov:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T06:58:11Z

This PR (HEAD: f43af96) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-18T11:06:41Z

Message from Jorropo:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T18:01:35Z

This PR (HEAD: e0537d1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-18T18:10:45Z

Message from Max Neverov:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:10:48Z

Message from Jorropo:

Patch Set 4: Code-Review+1 Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:10:48Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-18T19:02:38Z","revision":"4ee11b1d946106f1956ddbd9524d4e0d87db56b9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:28:41Z

Message from Jorropo:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:28:42Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 628596)

Build or test failure, click here for results.

To reproduce, try gomote repro 8730905631194697569.

Additional links for debugging:

Output for go tool dist test -json [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-18T19:28:42Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-20T19:27:35Z

Message from Sam Thanawalla:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T06:36:04Z

This PR (HEAD: 0684661) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-21T06:51:26Z

Message from Max Neverov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:45:42Z

Message from Jorropo:

Patch Set 5: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:54:19Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-21T10:38:11Z","revision":"98d9ceeb6dc9250466c0dae622c66eabe580c1cc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:54:19Z

Message from Jorropo:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-21T10:54:20Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

go on master (change 628596)
tools on master (commit 9dff42e)

Build or test failure, click here for results.

To reproduce, try gomote repro 8730665570262035233.

Additional links for debugging:

Output for test golang.org/x/tools module

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-11T05:08:51Z

This PR (HEAD: 957fd30) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-01-15T19:51:27Z

Message from Sam Thanawalla:

Patch Set 10: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-25T08:26:52Z

Message from qiu laidongfeng2:

Patch Set 10: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-25T08:26:52Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-01-25T08:18:17Z","revision":"a4fedf8f2a1bfa608dcc966ba9a85e7c814f9b48"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-25T08:34:44Z

Message from qiu laidongfeng2:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-25T08:34:44Z

Message from Go LUCI:

Patch Set 10:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-newinliner has failed with summary (view all results):

go on master (change 628596)

Build or test failure, click here for results.

To reproduce, try gomote repro 8724785575194670161.

Additional links for debugging:

Output for go tool dist test -json [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-25T08:34:45Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-18T19:00:20Z

Message from Michael Matloob:

Patch Set 10: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-18T20:02:09Z

This PR (HEAD: e2063d1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/628596.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-18T20:18:52Z

Message from f u:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-18T20:33:39Z

Message from Michael Matloob:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-19T03:18:34Z

Message from f u:

Patch Set 11:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-19T14:39:13Z

Message from Michael Matloob:

Patch Set 11: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-19T14:50:53Z

Message from Go LUCI:

Patch Set 11:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-19T14:25:27Z","revision":"1bb82e4a45abcec514735c33eb5b6df70b023104"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-19T14:50:54Z

Message from Michael Matloob:

Patch Set 11: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-19T15:09:41Z

Message from Michael Matloob:

Patch Set 11: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-19T15:09:42Z

Message from Go LUCI:

Patch Set 11:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-19T15:09:42Z

Message from Go LUCI:

Patch Set 11: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-19T16:39:50Z

Message from Michael Matloob:

Patch Set 11: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/628596.
After addressing review feedback, remember to publish your drafts!

Currently, if computing of the go cache directory fails it does not expose the error. Commands like go clean, exec, modindex that use go cache directory continue execution producing incorrect or no result. This patch adds an error to the return values such that it can be validated on call sites. It also introduces such validation in go clean -cache command to fail execution in case when error occurred. Fixes #69997 Change-Id: I53fd1ec67f0a6bd8a367e785dcb145a673c084dc GitHub-Last-Rev: e2063d1 GitHub-Pull-Request: #70392 Reviewed-on: https://go-review.googlesource.com/c/go/+/628596 Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Michael Matloob <matloob@golang.org>

gopherbot · 2025-03-20T16:12:57Z

This PR is being closed because golang.org/cl/628596 has been merged.

mneverov added 5 commits January 11, 2025 06:02

Add test.

d795952

Add errcheck when initializing default cache.

8c856bb

Remove obsolete errcheck.

2e6e351

Fix GOCACHE doc comment.

8084eba

Fix GOCACHE doc comment again.

957fd30

mneverov force-pushed the fix/clean branch from 722da12 to 957fd30 Compare January 11, 2025 05:03

Update helpdoc.

e2063d1

mneverov force-pushed the fix/clean branch from 1a3c63d to e2063d1 Compare March 18, 2025 20:00

gopherbot closed this Mar 20, 2025

cmd/go: fail go clean command when failed to find go cache directory #70392

cmd/go: fail go clean command when failed to find go cache directory #70392

Conversation

mneverov commented Nov 16, 2024 • edited Loading

gopherbot commented Nov 16, 2024

gopherbot commented Nov 16, 2024

gopherbot commented Nov 16, 2024

gopherbot commented Nov 16, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 17, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 18, 2024

gopherbot commented Nov 20, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Nov 21, 2024

gopherbot commented Jan 11, 2025

gopherbot commented Jan 15, 2025

gopherbot commented Jan 25, 2025

gopherbot commented Jan 25, 2025

gopherbot commented Jan 25, 2025

gopherbot commented Jan 25, 2025

gopherbot commented Jan 25, 2025

gopherbot commented Mar 18, 2025

gopherbot commented Mar 18, 2025

gopherbot commented Mar 18, 2025

gopherbot commented Mar 18, 2025

gopherbot commented Mar 19, 2025

gopherbot commented Mar 19, 2025

gopherbot commented Mar 19, 2025

gopherbot commented Mar 19, 2025

gopherbot commented Mar 19, 2025

gopherbot commented Mar 19, 2025

gopherbot commented Mar 19, 2025

gopherbot commented Mar 19, 2025

gopherbot commented Mar 20, 2025

mneverov commented Nov 16, 2024 •

edited

Loading