tiff, bmp: return io.UnexpectedEOF on empty data

[oneslash]

Check for an EOF when decoding the tiff and bmp headers,
so that decoding empty data does not return an EOF.

Fixes golang/go#11391

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[gopherbot]

This PR (HEAD: ee7b450) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/205458 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Akhil Indurti:

Patch Set 1:

(4 comments)

Hey Sardorbek,

Thank you for submitting this! Just some feedback on the commit message.

Akhil

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 772852b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/205458 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Sardorbek Pulatov:

Patch Set 2:

@akhil, I have edited the commit message. Thank you for the review

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Akhil Indurti:

Patch Set 2:

Patch Set 2:

@akhil, I have edited the commit message. Thank you for the review

It appears that the commit message hasn't changed on Gerrit. Since you are
using a Pull Request, you must edit the PR’s title and description to update
the CL here. See https://github.com/golang/go/wiki/CommitMessage#github-pull-requests
for more information.

Additionally, please move the “Fixes #11391” line to the bottom of the commit
message as per the formatting guidelines.

Thanks

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: dc261cf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/205458 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Sardorbek Pulatov:

Patch Set 5:

Thank you, now it seems like its good

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Akhil Indurti:

Patch Set 5: Run-TryBot+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 5:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=043ec183

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 5: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Akhil Indurti:

Patch Set 5: -Run-TryBot Code-Review+1

Looks good.
Kindly pinging Nigel

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Nigel Tao:

Patch Set 5:

(3 comments)

Looks good. Just a couple of minor things to fix.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 19a70c0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/205458 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Sardorbek Pulatov:

Patch Set 6:

Thank you Nigel for review, I have done the changes.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Akhil Indurti:

Patch Set 6:

(4 comments)

Hey Sardorbek,

It appears that Nigel's requested changes were not made in the latest patchset. I have marked them again here.

Thanks

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Sardorbek Pulatov:

Patch Set 6:

@akhil, I have added about nil case the test below []byte{}, do you think only nil case should stay?

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Nigel Tao:

Patch Set 6:

Patch Set 6:

@akhil, I have added about nil case the test below []byte{}, do you think only nil case should stay?

Please just have the nil case, and delete the []byte{} case.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 0e266b4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/205458 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Sardorbek Pulatov:

Patch Set 6:

Patch Set 6:

Patch Set 6:

@akhil, I have added about nil case the test below []byte{}, do you think only nil case should stay?

Please just have the nil case, and delete the []byte{} case.

Fixed, Nigel, thank you for the comments

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Akhil Indurti:

Patch Set 7:

(2 comments)

Minor nitpick, thanks for working on this!

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR (HEAD: 924636f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/image/+/205458 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

[gopherbot]

Message from Akhil Indurti:

Patch Set 7: Run-TryBot+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=6dae6658

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Sardorbek Pulatov:

Patch Set 7:

Akhil, removed, thank you 😊

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Akhil Indurti:

Patch Set 8: Run-TryBot+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 8:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=90e694e4

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gobot Gobot:

Patch Set 8: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Akhil Indurti:

Patch Set 8: Code-Review+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/205458.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/205458 has been merged.