Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Generating mocks (reflect mode) fails if interface contains methods with generic types #677

Closed
@daolis

Description

@daolis

Generating mocks (reflect mode) fails with Failed to format generated source code: if the interface contains methods with generic types.

The generated code contains the full package path as the type.
The wrong type is returned from reflect.typeOf (see golang/go#55147)

Reproduceable with

package test

import (
	_ "github.com/golang/mock/gomock"
)

type TestType string

type TestGenericType[T any] struct {
	blaa T
}

//go:generate mockgen -destination zz_generated_mock.go -package mockst . TestGenericInterface

type TestGenericInterface interface {
	TestMethod() TestGenericType[TestType]
}

generated file contains e.g. this method

// TestMethod mocks base method.
func (m *MockTestGenericInterface) TestMethod() test.TestGenericType[github.com/daolis/mockgentest/test.TestType] {
        m.ctrl.T.Helper()
        ret := m.ctrl.Call(m, "TestMethod")
        ret0, _ := ret[0].(test.TestGenericType[github.com/daolis/mockgentest/test.TestType])
        return ret0
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions