Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix: Support array parsing with length using binary expression and parenthesis #603

Merged
merged 2 commits into from
Dec 30, 2021
Merged

fix: Support array parsing with length using binary expression and parenthesis #603

merged 2 commits into from
Dec 30, 2021

Conversation

sryoya
Copy link
Contributor

@sryoya sryoya commented Dec 10, 2021

Fixes #575

@sryoya
fix parse array length with binary expression or parenthesis
2bc3069 
fix func name for parsing array length

run mockgen against newly updated test file
@sryoya sryoya requested a review from codyoss as a code owner December 10, 2021 11:21
codyoss
codyoss approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the slow review!

@codyoss codyoss merged commit cf7e215 into golang:master Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support array parsing with length using binary expression and parenthesis
2 participants
@sryoya @codyoss