Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sumdb/dirhash: fix a panic when argument is not a directory #16

Closed
wants to merge 1 commit into from
Closed

sumdb/dirhash: fix a panic when argument is not a directory #16

wants to merge 1 commit into from

Conversation

simar7
Copy link
Contributor

@simar7 simar7 commented Dec 12, 2022 •
edited
Loading

This patch fixes a case where a path to a non directory can cause DirHash func to panic.

Fixes golang/go#57269

@simar7 simar7 mentioned this pull request Dec 12, 2022
Closed
@gopherbot
Copy link
Contributor

This PR (HEAD: 26b037e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/457075 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 9fbbc03) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/457075 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kuma:

Patch Set 2:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e3d0940) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/457075 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kuma:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 3: Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@simar7
sumdb/dirhash: fix a panic when argument is not a directory
a17ca1a 
This patch fixes a case where a path to a non directory
can cause DirHash func to panic.

Fixes: golang/go#57269.
@gopherbot
Copy link
Contributor

This PR (HEAD: a17ca1a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/457075 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 4: Auto-Submit+1 Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Kuma:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/457075.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 16, 2023
@simar7 @gopherbot
sumdb/dirhash: fix a panic when argument is not a directory
77d797e 
This patch fixes a case where a path to a non directory can cause DirHash func to panic.

Fixes golang/go#57269

Change-Id: I743970dcafdf3bfee94baf4b714429a404decda9
GitHub-Last-Rev: a17ca1a
GitHub-Pull-Request: #16
Reviewed-on: https://go-review.googlesource.com/c/mod/+/457075
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Benny Siegert <bsiegert@gmail.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/457075 has been merged.

@gopherbot gopherbot closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/mod/sumdb/dirhash: panic observed traversing tmp dir
2 participants
@simar7 @gopherbot