Skip to content

dns/dnsmessage: add AD and CD bits support #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

dns/dnsmessage: add AD and CD bits support #136

wants to merge 2 commits into from

Conversation

mateusz834
Copy link
Member

@mateusz834 mateusz834 commented May 25, 2022 •
edited
Loading

@gopherbot
Copy link
Contributor

This PR (HEAD: 52e39ab) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/408654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@mateusz834 mateusz834 mentioned this pull request May 25, 2022
Closed
@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 1: Run-TryBot+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@mateusz834 mateusz834 changed the title dns/dnsmessage: add AD flag support dns/dnsmessage: add AD bit support May 25, 2022
@gopherbot
Copy link
Contributor

Message from Mateusz Poliwczak:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: c5ef8a5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/408654 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@mateusz834 mateusz834 changed the title dns/dnsmessage: add AD bit support dns/dnsmessage: add AD and CD bits support May 25, 2022
@gopherbot
Copy link
Contributor

Message from Mateusz Poliwczak:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Mateusz Poliwczak:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Mateusz Poliwczak:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 5: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 5: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Mateusz Poliwczak:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Mateusz Poliwczak:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408654.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 9, 2022
@mateusz834 @neild
dns/dnsmessage: add AD and CD bits support
07c6da5 
For golang/go#51152

Change-Id: I1e348afaa1533849e682194efb1c404f9e678e56
GitHub-Last-Rev: c5ef8a5
GitHub-Pull-Request: #136
Reviewed-on: https://go-review.googlesource.com/c/net/+/408654
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/408654 has been merged.

@gopherbot gopherbot closed this Aug 9, 2022
WeiminShang added a commit to WeiminShang/net that referenced this pull request Nov 16, 2022
@WeiminShang @neild
dns/dnsmessage: add AD and CD bits support
753e8c6 
For golang/go#51152

Change-Id: I1e348afaa1533849e682194efb1c404f9e678e56
GitHub-Last-Rev: c5ef8a56ad1d85645c95f25e719a476595063471
GitHub-Pull-Request: golang/net#136
Reviewed-on: https://go-review.googlesource.com/c/net/+/408654
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusz834 @gopherbot