route: fix RTM_GET netmask parsing on Darwin #232

hurricanehrndz · 2025-02-06T18:05:45Z

On Darwin, the AF_FAMILY byte of a sockaddr for a netmask or genmask
can be ignored if unreasonable. In such cases, it is the family of the
DST address that should instead be used.

Additionally, fixing faulty test data. 192.168.86.0 is a Class C network
address, that should have a subnet mask of 255.255.255.0. What's more is
the data can also be flag as incorrect considering structure padding
rules alone.

Further more, you can validate that route get will never actually return a
netmask for a host query, even though it should be 255.255.255.255.

You can run the following to check:
route -n get -host 127.0.0.1

You will note the reply has no mention of netmask.

Depends on CL 646556..
Fixes golang/go#71578.

Previously, we enforced minimum length requirements for sockaddr, but the route command can legitimately parse shorter lengths. This change treats any sockaddr with length less than the address offset as an unspecified address (0.0.0.0 for IPv4 or :: for IPv6), as discern by monitoring the route command. To replicate the issue, prior to the fix, execute the following: First, ```console route -n monitor ``` Next, ```console sudo route -n add -inet6 -ifscope en11 -net :: \ -netmask :: fe80::2d0:4cff:fe10:15d2 ``` The route command that is actively monitor will print something such as, ```console RTM_ADD: Add Route: len 152, pid: 81198, seq 1, errno 0, ifscope 13, flags:<UP,GATEWAY,DONE,STATIC,IFSCOPE> locks: inits: sockaddrs: <DST,GATEWAY,NETMASK> :: fe80::2d0:4cff:fe10:15d2 :: ``` Prior to the fix, if you had parse the above message, PareRIB would have returned errInvalidAddr which is clearly false. Fixes golang/go#71557

On Darwin, the AF_FAMILY byte of a sockaddr for a netmask or genmask can be ignored if unreasonable. In such cases, it is the family of the DST address that should instead be used. Depends on golang#231. Fixes golang/go#71578.

gopherbot · 2025-02-06T18:17:30Z

This PR (HEAD: a116280) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/647176.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

192.168.86.0 is a Class C network address, that should have a subnet mask of 255.255.0. The test data can also immediately be flag as incorrect taking structure padding rules alone.

gopherbot · 2025-02-06T18:34:27Z

This PR (HEAD: cf31cbc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/647176.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

* origin/master: route: treat short sockaddr lengths as unspecified internal/http3: refactor in prep for sharing transport/server code

gopherbot · 2025-02-06T20:34:41Z

This PR (HEAD: b36e447) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/647176.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-06T20:43:08Z

Message from Ian Lance Taylor:

Patch Set 3:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T20:51:24Z

This PR (HEAD: acc25d7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/647176.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-06T21:00:02Z

This PR (HEAD: f07e0af) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/647176.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-06T21:25:01Z

Message from Carlos Hernandez:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T21:50:53Z

Message from Ian Lance Taylor:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T21:50:57Z

This PR (HEAD: 0ace28a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/647176.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-06T21:59:44Z

Message from Carlos Hernandez:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T22:25:36Z

Message from Ian Lance Taylor:

Patch Set 7: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T22:34:08Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-06T22:15:30Z","revision":"3942b7365ede2beb6e233519b2250fd5c9105e67"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T22:34:09Z

Message from Ian Lance Taylor:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T22:34:09Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/x_net-go1.22-darwin-amd64_14 has failed with summary (view all results):

go on release-branch.go1.22 (commit 5817e65)
net on master (change 647176)

Build or test failure, click here for results.

To reproduce, try gomote repro 8723645739602663873.

Additional links for debugging:

Output for test golang.org/x/net module

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T22:34:10Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-06T22:42:33Z

Message from Ian Lance Taylor:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T00:34:50Z

This PR (HEAD: e66491a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/647176.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-07T00:42:35Z

Message from Carlos Hernandez:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T00:59:05Z

Message from Ian Lance Taylor:

Patch Set 8: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:06:57Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-07T00:50:40Z","revision":"4d0930c8d6078494b1816c71c591ba64ea62d74b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:06:57Z

Message from Ian Lance Taylor:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:06:58Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:06:58Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:06:58Z

Message from Ian Lance Taylor:

Patch Set 8: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:14:34Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-07T00:59:26Z","revision":"4d0930c8d6078494b1816c71c591ba64ea62d74b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:14:34Z

Message from Ian Lance Taylor:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:14:34Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T01:22:14Z

Message from Damien Neil:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

The strategy here is to use mask when available otherwise if it is a netmask address it will try to fallback on af.

gopherbot · 2025-02-07T02:02:27Z

This PR (HEAD: 20064b2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/net/+/647176.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-02-07T02:10:12Z

Message from Carlos Hernandez:

Patch Set 8:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-07T19:28:20Z

Message from Damien Neil:

Patch Set 9: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-08T02:55:58Z

Message from Ian Lance Taylor:

Patch Set 9: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-08T03:05:15Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-02-08T02:48:26Z","revision":"dbf93d9bb351f03b4b10e607e7fde31356199184"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-08T03:05:16Z

Message from Ian Lance Taylor:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-08T03:05:16Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-08T03:05:17Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/647176.
After addressing review feedback, remember to publish your drafts!

hurricanehrndz added 2 commits February 4, 2025 17:22

route: fix RTM_GET netmask parsing on Darwin

a116280

On Darwin, the AF_FAMILY byte of a sockaddr for a netmask or genmask can be ignored if unreasonable. In such cases, it is the family of the DST address that should instead be used. Depends on golang#231. Fixes golang/go#71578.

route: fix faulty test data

cf31cbc

192.168.86.0 is a Class C network address, that should have a subnet mask of 255.255.0. The test data can also immediately be flag as incorrect taking structure padding rules alone.

Merge remote-tracking branch 'origin/master' into fix_golang_go_71578

b36e447

* origin/master: route: treat short sockaddr lengths as unspecified internal/http3: refactor in prep for sharing transport/server code

hurricanehrndz force-pushed the fix_golang_go_71578 branch from acc25d7 to f07e0af Compare February 6, 2025 20:58

route: fix case statement complexity

0ace28a

hurricanehrndz force-pushed the fix_golang_go_71578 branch from f07e0af to 0ace28a Compare February 6, 2025 21:46

route: fix tests

e66491a

hurricanehrndz added 2 commits February 6, 2025 18:52

route: isMask is not necessary here

9c9e4d9

The strategy here is to use mask when available otherwise if it is a netmask address it will try to fallback on af.

route: fix doc string

20064b2

route: fix RTM_GET netmask parsing on Darwin #232

Are you sure you want to change the base?

route: fix RTM_GET netmask parsing on Darwin #232

Conversation

hurricanehrndz commented Feb 6, 2025 • edited Loading

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 6, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 7, 2025

gopherbot commented Feb 8, 2025

gopherbot commented Feb 8, 2025

gopherbot commented Feb 8, 2025

gopherbot commented Feb 8, 2025

gopherbot commented Feb 8, 2025

hurricanehrndz commented Feb 6, 2025 •

edited

Loading